Skip to content

argagg: fix build with cmake4#455090

Merged
JohnRTitor merged 1 commit intoNixOS:masterfrom
iedame:cmake4/argagg
Oct 25, 2025
Merged

argagg: fix build with cmake4#455090
JohnRTitor merged 1 commit intoNixOS:masterfrom
iedame:cmake4/argagg

Conversation

@iedame
Copy link
Contributor

@iedame iedame commented Oct 24, 2025 •
edited
Loading

closes #455089

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 9.needs: reviewer This PR currently has no reviewers requested and needs attention. labels Oct 24, 2025
@iedame iedame mentioned this pull request Oct 24, 2025
Merged
13 tasks
@iedame
Copy link
Contributor Author

iedame commented Oct 24, 2025

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 455090
Commit: ea7e6cf35fdae37dd79ab43567385e38f8b0ac9f (subsequent changes)
Merge: f2140600087e577e364e7813512cc33193a9a528

Logs: https://github.com/iedame/nixpkgs-review-gha/actions/runs/18767494604

x86_64-linux

❌ 2 packages failed to build:
  • appimageupdate
  • appimageupdate-qt
✅ 1 package built:
  • argagg

aarch64-linux

❌ 2 packages failed to build:
  • appimageupdate
  • appimageupdate-qt
✅ 1 package built:
  • argagg

x86_64-darwin (sandbox = true)

✅ 1 package built:
  • argagg

aarch64-darwin

✅ No rebuilds

@Sigmanificient Sigmanificient mentioned this pull request Oct 24, 2025
Open
@iedame iedame mentioned this pull request Oct 24, 2025
Merged
13 tasks
@JohnRTitor JohnRTitor added this pull request to the merge queue Oct 25, 2025
Merged via the queue into NixOS:master with commit 6a7b1fa Oct 25, 2025
33 of 35 checks passed
@iedame iedame deleted the cmake4/argagg branch October 25, 2025 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JohnRTitor JohnRTitor JohnRTitor approved these changes

Assignees

No one assigned

Labels

9.needs: reviewer This PR currently has no reviewers requested and needs attention. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Build failure: argagg

2 participants

@iedame @JohnRTitor