Skip to content

podofo_0_9: fix build with cmake4#455067

Merged
SuperSandro2000 merged 1 commit intoNixOS:masterfrom
iedame:cmake4/podofo_0_9
Nov 1, 2025
Merged

podofo_0_9: fix build with cmake4#455067
SuperSandro2000 merged 1 commit intoNixOS:masterfrom
iedame:cmake4/podofo_0_9

Conversation

@iedame
Copy link
Contributor

@iedame iedame commented Oct 23, 2025

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Oct 23, 2025
@nix-owners nix-owners bot requested a review from kuflierl October 23, 2025 23:51
@iedame
Copy link
Contributor Author

iedame commented Oct 24, 2025

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 455067
Commit: e68bdabd632ed15be007fc969b8073f65347550d (subsequent changes)
Merge: 111a83f306aa1df2f217216d560309bb14cc450d

Logs: https://github.com/iedame/nixpkgs-review-gha/actions/runs/18765230504

x86_64-linux

✅ 3 packages built:
  • podofo_0_9
  • podofo_0_9.dev
  • podofo_0_9.lib

aarch64-linux

✅ 3 packages built:
  • podofo_0_9
  • podofo_0_9.dev
  • podofo_0_9.lib

x86_64-darwin (sandbox = true)

✅ 3 packages built:
  • podofo_0_9
  • podofo_0_9.dev
  • podofo_0_9.lib

aarch64-darwin (sandbox = true)

✅ 3 packages built:
  • podofo_0_9
  • podofo_0_9.dev
  • podofo_0_9.lib

@Sigmanificient Sigmanificient mentioned this pull request Oct 24, 2025
Open
kuflierl
kuflierl approved these changes Oct 31, 2025
View reviewed changes
Copy link
Member

@kuflierl kuflierl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nixos-discourse
Copy link

nixos-discourse commented Oct 31, 2025

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/2620

@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels Oct 31, 2025
@SuperSandro2000 SuperSandro2000 added this pull request to the merge queue Nov 1, 2025
Merged via the queue into NixOS:master with commit 400a218 Nov 1, 2025
35 of 36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@kuflierl kuflierl kuflierl approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@iedame @nixos-discourse @kuflierl @SuperSandro2000