Skip to content

opl3bankeditor: fix build with cmake4#455048

Merged
OPNA2608 merged 1 commit intoNixOS:masterfrom
iedame:cmake4/opl3bankeditor
Nov 4, 2025
Merged

opl3bankeditor: fix build with cmake4#455048
OPNA2608 merged 1 commit intoNixOS:masterfrom
iedame:cmake4/opl3bankeditor

Conversation

@iedame
Copy link
Contributor

@iedame iedame commented Oct 23, 2025 •
edited
Loading

This also fixes opn2bankeditor since they share a common nix file.

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. labels Oct 23, 2025
@nix-owners nix-owners bot requested a review from OPNA2608 October 23, 2025 22:38
@iedame
Copy link
Contributor Author

iedame commented Oct 23, 2025

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 455048
Commit: 7bede7dd99b04ddfc02e94bf0c495253ae5be21d (subsequent changes)
Merge: f5fec7eda20f2806776ac44c28421d13e51b8b9a

Logs: https://github.com/iedame/nixpkgs-review-gha/actions/runs/18764013568

x86_64-linux

✅ 2 packages built:
  • opl3bankeditor
  • opn2bankeditor

aarch64-linux

✅ 2 packages built:
  • opl3bankeditor
  • opn2bankeditor

x86_64-darwin (sandbox = true)

❌ 2 packages failed to build:
  • opl3bankeditor
  • opn2bankeditor

aarch64-darwin (sandbox = true)

❌ 2 packages failed to build:
  • opl3bankeditor
  • opn2bankeditor

@iedame
Copy link
Contributor Author

iedame commented Oct 23, 2025

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 455048
Commit: 7bede7dd99b04ddfc02e94bf0c495253ae5be21d (subsequent changes)
Merge: ed3e617fbe41dae576efc87623cdbaaece5502b3

Logs: https://github.com/iedame/nixpkgs-review-gha/actions/runs/18764582444

x86_64-darwin (sandbox = false)

✅ 2 packages built:
  • opl3bankeditor
  • opn2bankeditor

aarch64-darwin (sandbox = false)

✅ 2 packages built:
  • opl3bankeditor
  • opn2bankeditor

@iedame
Copy link
Contributor Author

iedame commented Oct 23, 2025

Darwin failure is due to sandbox and shouldn't be a problem.

@Sigmanificient Sigmanificient mentioned this pull request Oct 24, 2025
Open
@iedame iedame added the 0.kind: ZHF Fixes Fixes during the Zero Hydra Failures (ZHF) campaign label Nov 3, 2025
OPNA2608
OPNA2608 approved these changes Nov 4, 2025
View reviewed changes
Copy link
Contributor

@OPNA2608 OPNA2608 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The better solution is prolly to uncouple opl3bankeditor and opn2bankeditor from each other into separate packages, and turn each into an unstable package. The most recent release for each of them was 5y ago, and opl3bankeditor has a release in master that fixes the CMake version thing.

But these recent CMake 4 fixes are mostly drive-by, and I don't have the energy right now to implement the above (or submit the change to the upstreams that are still missing it, so more people benefit from this patching effort - winkwink nudgenudge…).

This'll do for now, I guess. 😕

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 455048
Commit: 7bede7dd99b04ddfc02e94bf0c495253ae5be21d

x86_64-linux

✅ 3 packages built:
  • nixpkgs-manual
  • opl3bankeditor
  • opn2bankeditor

Both launch & work fine.

@OPNA2608 OPNA2608 added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels Nov 4, 2025
@OPNA2608 OPNA2608 added this pull request to the merge queue Nov 4, 2025
Merged via the queue into NixOS:master with commit 6220c02 Nov 4, 2025
36 of 37 checks passed
@iedame iedame deleted the cmake4/opl3bankeditor branch November 4, 2025 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@OPNA2608 OPNA2608 OPNA2608 approved these changes

Assignees

No one assigned

Labels

0.kind: ZHF Fixes Fixes during the Zero Hydra Failures (ZHF) campaign 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@iedame @OPNA2608