Skip to content

opengv: fix build with cmake4#455035

Merged
pyrox0 merged 1 commit intoNixOS:masterfrom
iedame:cmake4/opengv
Oct 25, 2025
Merged

opengv: fix build with cmake4#455035
pyrox0 merged 1 commit intoNixOS:masterfrom
iedame:cmake4/opengv

Conversation

@iedame
Copy link
Contributor

@iedame iedame commented Oct 23, 2025

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Oct 23, 2025
@nix-owners nix-owners bot requested a review from loco-choco October 23, 2025 21:37
@Sigmanificient Sigmanificient mentioned this pull request Oct 23, 2025
Open
@iedame
Copy link
Contributor Author

iedame commented Oct 23, 2025

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 455035
Commit: 5bab9cf4efe3ddc21f63db5817e1710f75983d52 (subsequent changes)
Merge: d4e5af0beb2a3276451f035e7fc793616fa53f55

Logs: https://github.com/iedame/nixpkgs-review-gha/actions/runs/18763218762

x86_64-linux

✅ 1 package built:
  • opengv

aarch64-linux

✅ 1 package built:
  • opengv

x86_64-darwin (sandbox = true)

✅ 1 package built:
  • opengv

aarch64-darwin (sandbox = true)

✅ 1 package built:
  • opengv

@loco-choco
Copy link
Member

loco-choco commented Oct 25, 2025

@NixOS/nixpkgs-merge-bot merge

@nixpkgs-merge-bot
Copy link
Contributor

nixpkgs-merge-bot bot commented Oct 25, 2025

@loco-choco merge not permitted (#305350):
R-Ryantm Maintainer merge: pr author is not r-ryantm
CommitterPR: pr author is not committer

@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels Oct 25, 2025
@pyrox0 pyrox0 added this pull request to the merge queue Oct 25, 2025
Merged via the queue into NixOS:master with commit 940e933 Oct 25, 2025
34 of 36 checks passed
@iedame iedame deleted the cmake4/opengv branch October 25, 2025 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@loco-choco loco-choco loco-choco approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@iedame @loco-choco @pyrox0