Skip to content

nootka: fix build with cmake4#454992

Merged
Sigmanificient merged 1 commit intoNixOS:masterfrom
iedame:cmake4/nootka
Oct 28, 2025
Merged

nootka: fix build with cmake4#454992
Sigmanificient merged 1 commit intoNixOS:masterfrom
iedame:cmake4/nootka

Conversation

@iedame
Copy link
Contributor

@iedame iedame commented Oct 23, 2025

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Oct 23, 2025
@nix-owners nix-owners bot requested review from mmlb and orivej October 23, 2025 19:04
@iedame
Copy link
Contributor Author

iedame commented Oct 23, 2025

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 454992
Commit: 1bb9574ac84270bc01f508953df418f1b230552c (subsequent changes)
Merge: 19e1196ea5e8ce6e7237dc5d9ae9b13da43211e2

Logs: https://github.com/iedame/nixpkgs-review-gha/actions/runs/18759307029

x86_64-linux

✅ 1 package built:
  • nootka

aarch64-linux

✅ 1 package built:
  • nootka

x86_64-darwin

✅ No rebuilds

aarch64-darwin

✅ No rebuilds

@Sigmanificient Sigmanificient mentioned this pull request Oct 23, 2025
Open
mmlb
mmlb approved these changes Oct 26, 2025
View reviewed changes
Copy link
Member

@mmlb mmlb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels Oct 26, 2025
@Sigmanificient Sigmanificient added this pull request to the merge queue Oct 28, 2025
Merged via the queue into NixOS:master with commit a672d84 Oct 28, 2025
33 of 35 checks passed
@iedame iedame deleted the cmake4/nootka branch October 28, 2025 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@orivej orivej Awaiting requested review from orivej

1 more reviewer

@mmlb mmlb mmlb approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@iedame @mmlb @Sigmanificient