Skip to content

splitcode: 0.31.3 -> 0.31.4#454808

Merged
Sigmanificient merged 1 commit intoNixOS:masterfrom
zimward:push-prwwpqztnqzy
Oct 31, 2025
Merged

splitcode: 0.31.3 -> 0.31.4#454808
Sigmanificient merged 1 commit intoNixOS:masterfrom
zimward:push-prwwpqztnqzy

Conversation

@zimward
Copy link
Contributor

@zimward zimward commented Oct 23, 2025

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 9.needs: reviewer This PR currently has no reviewers requested and needs attention. labels Oct 23, 2025
@nartsisss
Copy link
Member

nartsisss commented Oct 23, 2025

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 454808
Commit: 266856b7e02f9b58a25705276c1463c5ca38c7c4 (subsequent changes)
Merge: bd8d83a269b4c5ec82046262f53b8a8f7b58878e

Logs: https://github.com/nartsisss/nixpkgs-review-gha/actions/runs/18742702071

x86_64-linux

✅ 1 package built:
  • splitcode

aarch64-linux

✅ No rebuilds

x86_64-darwin (sandbox = true)

❌ 1 package failed to build:
  • splitcode
Error logs: `x86_64-darwin`
splitcode 
  114 | #  define OS_CODE 19
      |           ^
/nix/build/nix-11123-3606565695/source/ext/zlib-ng/arch/x86/../../zutil.h:102:11: note: previous definition is here
  102 | #  define OS_CODE  7
      |           ^
clang: warning: argument unused during compilation: '-fno-semantic-interposition' [-Wunused-command-line-argument]
clang: warning: argument unused during compilation: '-fno-semantic-interposition' [-Wunused-command-line-argument]
1 warning generated.
[ 96%] Building C object CMakeFiles/zlib.dir/gzlib.c.o
[ 97%] Building C object CMakeFiles/zlib.dir/gzread.c.o
[ 98%] Building C object CMakeFiles/zlib.dir/gzwrite.c.o
clang: warning: argument unused during compilation: '-fno-semantic-interposition' [-Wunused-command-line-argument]
clang: warning: argument unused during compilation: '-fno-semantic-interposition' [-Wunused-command-line-argument]
clang: warning: argument unused during compilation: '-fno-semantic-interposition' [-Wunused-command-line-argument]
[100%] Linking C shared library libz.dylib
[100%] Built target zlib
[ 90%] No install step for 'zlib-ng'
[ 95%] Completed 'zlib-ng'
[ 95%] Built target zlib-ng
make: *** [Makefile:136: all] Error 2

aarch64-darwin (sandbox = true)

✅ 1 package built:
  • splitcode

@iedame
Copy link
Contributor

iedame commented Oct 24, 2025

@Sigmanificient Sigmanificient mentioned this pull request Oct 25, 2025
Open
Sigmanificient
Sigmanificient requested changes Oct 26, 2025
View reviewed changes
Copy link
Member

@Sigmanificient Sigmanificient left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets document the opened pr

@nixpkgs-ci nixpkgs-ci bot removed the 9.needs: reviewer This PR currently has no reviewers requested and needs attention. label Oct 26, 2025
@Sigmanificient Sigmanificient added this pull request to the merge queue Oct 31, 2025
@Sigmanificient
Copy link
Member

Sigmanificient commented Oct 31, 2025

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 454808
Commit: 2f9f2dbc34a5e2c958e93b9d947f3a7a543bde0d (subsequent changes)
Merge: 539335dbf6c3bb175fb983ef42b54d99aa978c72

Logs: https://github.com/Sigmanificient/nixpkgs-review-gha/actions/runs/18986986602

x86_64-linux

✅ 1 package built:
  • splitcode

aarch64-linux

✅ No rebuilds

x86_64-darwin (sandbox = true)

❌ 1 package failed to build:
  • splitcode
Error logs: `x86_64-darwin`
splitcode 
[ 94%] Building C object CMakeFiles/zlibstatic.dir/arch/x86/adler32_ssse3.c.o
[ 95%] Building C object CMakeFiles/zlibstatic.dir/arch/x86/crc32_fold_pclmulqdq.c.o
In file included from /nix/build/nix-8184-707134722/source/ext/zlib-ng/arch/x86/slide_hash_sse2.c:12:
In file included from /nix/build/nix-8184-707134722/source/ext/zlib-ng/arch/x86/../../deflate.h:13:
/nix/build/nix-8184-707134722/source/ext/zlib-ng/arch/x86/../../zutil.h:114:11: warning: 'OS_CODE' macro redefined [-Wmacro-redefined]
  114 | #  define OS_CODE 19
      |           ^
/nix/build/nix-8184-707134722/source/ext/zlib-ng/arch/x86/../../zutil.h:102:11: note: previous definition is here
  102 | #  define OS_CODE  7
      |           ^
1 warning generated.
[ 96%] Building C object CMakeFiles/zlibstatic.dir/gzlib.c.o
[ 97%] Building C object CMakeFiles/zlibstatic.dir/gzread.c.o
[ 98%] Building C object CMakeFiles/zlibstatic.dir/gzwrite.c.o
[100%] Linking C static library libz.a
[100%] Built target zlibstatic
[ 90%] No install step for 'zlib-ng'
[ 95%] Completed 'zlib-ng'
[ 95%] Built target zlib-ng
make: *** [Makefile:136: all] Error 2

aarch64-darwin (sandbox = true)

✅ 1 package built:
  • splitcode

Merged via the queue into NixOS:master with commit 45c342f Oct 31, 2025
28 of 30 checks passed
@nixpkgs-ci nixpkgs-ci bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Oct 31, 2025
@zimward zimward deleted the push-prwwpqztnqzy branch November 1, 2025 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Sigmanificient Sigmanificient Sigmanificient approved these changes

Assignees

No one assigned

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@zimward @nartsisss @iedame @Sigmanificient