Skip to content

mkclean: fix build with cmake4#454681

Merged
Aleksanaa merged 1 commit intoNixOS:masterfrom
iedame:cmake4/mkclean
Nov 8, 2025
Merged

mkclean: fix build with cmake4#454681
Aleksanaa merged 1 commit intoNixOS:masterfrom
iedame:cmake4/mkclean

Conversation

@iedame
Copy link
Contributor

@iedame iedame commented Oct 22, 2025

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Oct 22, 2025
@nix-owners nix-owners bot requested a review from cawilliamson October 22, 2025 21:33
@iedame
Copy link
Contributor Author

iedame commented Oct 22, 2025

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 454681
Commit: 0dabfc547c5616a09426ef48b6b610e9585777ad (subsequent changes)
Merge: 98d6521733a7bf2205591b29422257dee6517cdc

Logs: https://github.com/iedame/nixpkgs-review-gha/actions/runs/18730628605

x86_64-linux

✅ 1 package built:
  • mkclean

aarch64-linux

✅ 1 package built:
  • mkclean

x86_64-darwin (sandbox = true)

✅ 1 package built:
  • mkclean

aarch64-darwin (sandbox = true)

✅ 1 package built:
  • mkclean

@Sigmanificient Sigmanificient mentioned this pull request Oct 23, 2025
Open
@iedame iedame added the 0.kind: ZHF Fixes Fixes during the Zero Hydra Failures (ZHF) campaign label Nov 3, 2025
@nixpkgs-ci nixpkgs-ci bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Nov 5, 2025
@Aleksanaa Aleksanaa added this pull request to the merge queue Nov 8, 2025
Merged via the queue into NixOS:master with commit 577aeeb Nov 8, 2025
36 of 37 checks passed
@iedame iedame deleted the cmake4/mkclean branch November 8, 2025 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cawilliamson cawilliamson Awaiting requested review from cawilliamson

1 more reviewer

@booxter booxter booxter approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

0.kind: ZHF Fixes Fixes during the Zero Hydra Failures (ZHF) campaign 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@iedame @booxter @Aleksanaa