Skip to content

mpw: fix cmake 4 compatibility#454631

Closed
SkohTV wants to merge 1 commit intoNixOS:masterfrom
SkohTV:cmake-fix-mpw
Closed

mpw: fix cmake 4 compatibility#454631
SkohTV wants to merge 1 commit intoNixOS:masterfrom
SkohTV:cmake-fix-mpw

Conversation

@SkohTV
Copy link
Member

@SkohTV SkohTV commented Oct 22, 2025 •
edited
Loading

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 9.needs: reviewer This PR currently has no reviewers requested and needs attention. labels Oct 22, 2025
@SkohTV
Copy link
Member Author

SkohTV commented Oct 22, 2025

nixpkgs-review result for #454631

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 454631
Commit: 8358b392b19dcb08ad81c9559f81099e04bd0f31 (subsequent changes)
Merge: 5dd89c5a9544af26849fa0c158e1daa895f196c5

Logs: https://github.com/SkohTV/nixpkgs-review-gha/actions/runs/18726710398

x86_64-linux

✅ 1 package built:
  • mpw

aarch64-linux

✅ 1 package built:
  • mpw

x86_64-darwin (sandbox = true)

✅ 1 package built:
  • mpw

aarch64-darwin (sandbox = true)

✅ 1 package built:
  • mpw

@Sigmanificient Sigmanificient mentioned this pull request Oct 23, 2025
Open
mdaniels5757
mdaniels5757 approved these changes Oct 24, 2025
View reviewed changes
Copy link
Member

@mdaniels5757 mdaniels5757 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diff and nixpkgs-review LGTM.

@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 1 This PR was reviewed and approved by one person. and removed 9.needs: reviewer This PR currently has no reviewers requested and needs attention. labels Oct 24, 2025
Sigmanificient
Sigmanificient requested changes Oct 26, 2025
View reviewed changes
Copy link
Member

@Sigmanificient Sigmanificient left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm i think this need a bit of an investigation. the site redirect to https://spectre.app

@mdaniels5757
Copy link
Member

mdaniels5757 commented Oct 26, 2025

Hmm i think this need a bit of an investigation. Upstream repository is gone, and the site redirect to https://spectre.app

The upstream repository at https://gitlab.com/MasterPassword/MasterPassword, and that links to spectre.app too.

@Sigmanificient
Copy link
Member

Sigmanificient commented Oct 26, 2025 •
edited
Loading

@mdaniels5757 Whoops i looked on github instead of gitlab 🙃

PROJECT MOVED
Master Password is announcing a massive rewrite, modernizing the solution and clearing the way for exciting new capabilities.
The project is re-launching as Spectre, still fully open- source Free Software here on GitLab.
[...]
All development effort has moved to the Spectre project. Master Password is no longer actively maintained.

I think we can drop this and look into shipping Spectre Desktop (Spectre CLI is already in nixpkgs)

@SkohTV
Copy link
Member Author

SkohTV commented Oct 26, 2025

Should we merge this in the meantime Spectre Desktop gets packaged ?
Or close this and drop the package (since doesn't build, there's no point just keeping it this way)

@Sigmanificient
Copy link
Member

Sigmanificient commented Oct 26, 2025

I think we shouldn't keep around a password manager that is no longer maintained

@SkohTV SkohTV closed this Oct 26, 2025
@mdaniels5757 mdaniels5757 mentioned this pull request Oct 26, 2025
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Sigmanificient Sigmanificient Sigmanificient requested changes

@mdaniels5757 mdaniels5757 mdaniels5757 approved these changes

Assignees

No one assigned

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@SkohTV @mdaniels5757 @Sigmanificient