Merged
Conversation
nixpkgs-ci
bot
added
10.rebuild-linux: 1-10
JohnRTitor
reviewed
Oct 22, 2025
nixpkgs-ci
bot
removed
the
9.needs: reviewer
deejayem
force-pushed
the
fix-msgpack-tools
branch
from
85206cd to
ee267cd
Compare
Contributor
JohnRTitor
reviewed
Oct 23, 2025
| url = "https://github.com/ludocode/mpack/archive/df17e83f0fa8571b9cd0d8ccf38144fa90e244d1.tar.gz"; | ||
| hash = "sha256-hyiXygbAHnNgF4TIg+DemBvtdBnSgJ7fAhknVuL+T/c="; | ||
| }; | ||
| in |
Member
There was a problem hiding this comment.
This makes it hard to override.
I would recommend moving it inside mkDerivation and access it via finalAttrs.
Co-authored-by: Petr Zahradnik <[email protected]>
deejayem
force-pushed
the
fix-msgpack-tools
branch
from
ee267cd to
3ce779c
Compare
Member
Author
|
Thank you, I hadn't seen that. It looks as though patching is preferred to using cmakeFlags, so I've changed that. Upstream has moved away from cmake, but there hasn't been a release for a long time, so I'll raise a ticket about that later on. |
JohnRTitor
approved these changes
Oct 23, 2025
nixpkgs-ci
bot
added
the
12.approvals: 1
Member
|
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, msgpack-tools fails to build for two reasons.
Firstly, it's specifying a cmake version that's too old, so we get an error about
Compatibility with CMake < 3.5 has been removed from CMake.Secondly, it fetches and tries to build a version of rapidjson that fails to compile.
This PR fixes those issues, and some other issues:
Note that the build scripts expect to find a tarball of mpack in a certain location, hence we still use fetchurl instead of fetchFromGitHub, as the latter unpacks it (and it seemed pointless to re-tar it, or to modify the upstream build scripts any more than I already have).
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.