Skip to content

megahit: fix build with cmake4#454580

Merged
Aleksanaa merged 1 commit intoNixOS:masterfrom
iedame:cmake4/megahit
Nov 8, 2025
Merged

megahit: fix build with cmake4#454580
Aleksanaa merged 1 commit intoNixOS:masterfrom
iedame:cmake4/megahit

Conversation

@iedame
Copy link
Contributor

@iedame iedame commented Oct 22, 2025

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Oct 22, 2025
@nix-owners nix-owners bot requested a review from luispedro October 22, 2025 15:45
@iedame
Copy link
Contributor Author

iedame commented Oct 22, 2025

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 454580
Commit: efecb81e39dcca3a9fe6f253a2a9b461e770d593 (subsequent changes)
Merge: 14e7ef5a531d59d52f7a137b7c8a8475998d04be

Logs: https://github.com/iedame/nixpkgs-review-gha/actions/runs/18721738899


x86_64-linux

✅ 1 package built:
  • megahit

aarch64-linux

No rebuilds


x86_64-darwin

No rebuilds


aarch64-darwin

No rebuilds

@iedame iedame added the 0.kind: ZHF Fixes Fixes during the Zero Hydra Failures (ZHF) campaign label Nov 3, 2025
Copy link
Contributor

@magicquark magicquark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diff LGTM.

But perhaps the version could be bumped to unstable as upstream has patched the CMakeLists now in commit.

@nixpkgs-ci nixpkgs-ci bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Nov 7, 2025
@booxter
Copy link
Contributor

booxter commented Nov 8, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 454580
Commit: efecb81e39dcca3a9fe6f253a2a9b461e770d593


x86_64-linux

✅ 1 package built:
  • megahit

Copy link
Contributor

@booxter booxter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved automatically following the successful run of nixpkgs-review.

@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 2 This PR was reviewed and approved by two persons. and removed 12.approvals: 1 This PR was reviewed and approved by one person. labels Nov 8, 2025
@Aleksanaa Aleksanaa added this pull request to the merge queue Nov 8, 2025
Merged via the queue into NixOS:master with commit c1d9176 Nov 8, 2025
37 of 38 checks passed
@iedame iedame deleted the cmake4/megahit branch November 8, 2025 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0.kind: ZHF Fixes Fixes during the Zero Hydra Failures (ZHF) campaign 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 2 This PR was reviewed and approved by two persons.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants