Skip to content

cloudcompare: fix build with cmake 4#454578

Merged
nh2 merged 2 commits intoNixOS:masterfrom
Philipp-M:cloudcompare-fix-cmake4
Oct 22, 2025
Merged

cloudcompare: fix build with cmake 4#454578
nh2 merged 2 commits intoNixOS:masterfrom
Philipp-M:cloudcompare-fix-cmake4

Conversation

@Philipp-M
Copy link
Member

I have tried to do this via patches, but I don't think it's worth the trouble/time as there's a lot of packages that need to be manually patched, so just use a global flag instead.

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Oct 22, 2025
@nix-owners nix-owners bot requested a review from nh2 October 22, 2025 15:41
@nixpkgs-ci nixpkgs-ci bot added 9.needs: reviewer This PR currently has no reviewers requested and needs attention. and removed 9.needs: reviewer This PR currently has no reviewers requested and needs attention. labels Oct 22, 2025
@nh2 nh2 added this pull request to the merge queue Oct 22, 2025
@nh2
Copy link
Contributor

nh2 commented Oct 22, 2025

Builds for me, I clicked "Merge when ready"

Merged via the queue into NixOS:master with commit 05705a9 Oct 22, 2025
26 of 30 checks passed
@Philipp-M Philipp-M deleted the cloudcompare-fix-cmake4 branch October 22, 2025 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants