Skip to content

luastatus: fix build with cmake4#454511

Merged
LordGrimmauld merged 1 commit intoNixOS:masterfrom
iedame:cmake4/luastatus
Nov 4, 2025
Merged

luastatus: fix build with cmake4#454511
LordGrimmauld merged 1 commit intoNixOS:masterfrom
iedame:cmake4/luastatus

Conversation

@iedame
Copy link
Contributor

@iedame iedame commented Oct 22, 2025

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Oct 22, 2025
@nix-owners nix-owners bot requested a review from kashw2 October 22, 2025 10:43
@iedame
Copy link
Contributor Author

iedame commented Oct 22, 2025

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 454511
Commit: a590702ecd1ed37e78d4d2329a3e8f62d3270292 (subsequent changes)
Merge: 821e13fcb055e6208ab26589ff2b563a6573043d

Logs: https://github.com/iedame/nixpkgs-review-gha/actions/runs/18713832583

x86_64-linux

✅ 1 package built:
  • luastatus

aarch64-linux

✅ 1 package built:
  • luastatus

x86_64-darwin

✅ No rebuilds

aarch64-darwin

✅ No rebuilds

@Sigmanificient Sigmanificient mentioned this pull request Oct 22, 2025
Open
@iedame iedame added the 0.kind: ZHF Fixes Fixes during the Zero Hydra Failures (ZHF) campaign label Nov 3, 2025
LordGrimmauld
LordGrimmauld approved these changes Nov 4, 2025
View reviewed changes
Copy link
Contributor

@LordGrimmauld LordGrimmauld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, upstream has a fix commit in shdown/luastatus@cbbf8a1, and imo we should prefer upstream fixes if they are already upstream.
That said: the patch here is trivial and does work, so i see no big issue with doing this.

@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 1 This PR was reviewed and approved by one person. 2.status: merge-bot eligible This PR can be merged by commenting "@NixOS/nixpkgs-merge-bot merge". labels Nov 4, 2025
@iedame
Copy link
Contributor Author

iedame commented Nov 4, 2025

Hmm, upstream has a fix commit in shdown/luastatus@cbbf8a1, and imo we should prefer upstream fixes if they are already upstream. That said: the patch here is trivial and does work, so i see no big issue with doing this.

@LordGrimmauld I didn't use upstream patch because the commit compatible to our version minimum have other changes that I'm not 100% sure are fine with our build: shdown/luastatus@5c5076e

I'm definitely okay with patching it if those should be fine, I was unsure so I used substituteInPlace as it was a trivial fix for this package.

@LordGrimmauld
Copy link
Contributor

LordGrimmauld commented Nov 4, 2025

Ah fair yeah, you'd need both of those commits to make it apply cleanly, not ideal. Substitute should be fine then.

@LordGrimmauld LordGrimmauld added this pull request to the merge queue Nov 4, 2025
Merged via the queue into NixOS:master with commit ded77f4 Nov 4, 2025
37 of 38 checks passed
@iedame iedame deleted the cmake4/luastatus branch November 4, 2025 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LordGrimmauld LordGrimmauld LordGrimmauld approved these changes

@kashw2 kashw2 Awaiting requested review from kashw2

Assignees

No one assigned

Labels

0.kind: ZHF Fixes Fixes during the Zero Hydra Failures (ZHF) campaign 2.status: merge-bot eligible This PR can be merged by commenting "@NixOS/nixpkgs-merge-bot merge". 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@iedame @LordGrimmauld