Skip to content

louvain-community, arjun-cnf: fix build with cmake4#454506

Merged
Sigmanificient merged 2 commits intoNixOS:masterfrom
iedame:cmake4/louvain-community
Oct 23, 2025
Merged

louvain-community, arjun-cnf: fix build with cmake4#454506
Sigmanificient merged 2 commits intoNixOS:masterfrom
iedame:cmake4/louvain-community

Conversation

@iedame
Copy link
Contributor

@iedame iedame commented Oct 22, 2025 •
edited
Loading

closes #454514
closes #454516

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. labels Oct 22, 2025
@nix-owners nix-owners bot requested a review from t4ccer October 22, 2025 10:24
@nixpkgs-ci nixpkgs-ci bot added the 9.needs: reviewer This PR currently has no reviewers requested and needs attention. label Oct 22, 2025
@iedame

This comment was marked as outdated.

Sign in to view
@nixpkgs-ci nixpkgs-ci bot removed the 9.needs: reviewer This PR currently has no reviewers requested and needs attention. label Oct 22, 2025
@iedame iedame marked this pull request as draft October 22, 2025 10:44
@iedame iedame marked this pull request as ready for review October 22, 2025 11:05
@iedame iedame changed the title louvain-community: fix build with cmake4 louvain-community, arjun-cnf: fix build with cmake4 Oct 22, 2025
@iedame
Copy link
Contributor Author

iedame commented Oct 22, 2025

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 454506
Commit: 9f62ff9ffdd9265c53838e719058a8c299dfd59f (subsequent changes)
Merge: 1382324f7e483073048b75589b048f5422839be5

Logs: https://github.com/iedame/nixpkgs-review-gha/actions/runs/18714136538

x86_64-linux

✅ 3 packages built:
  • approxmc
  • arjun-cnf
  • louvain-community

aarch64-linux

✅ 3 packages built:
  • approxmc
  • arjun-cnf
  • louvain-community

x86_64-darwin (sandbox = true)

✅ 1 package built:
  • louvain-community

aarch64-darwin (sandbox = true)

✅ 1 package built:
  • louvain-community

@t4ccer
Copy link
Member

t4ccer commented Oct 22, 2025

Can we do cmakeFlags = [ "-DCMAKE_POLICY_VERSION_MINIMUM=3.10" ]; instead of patching the cmake files?

@t4ccer
Copy link
Member

t4ccer commented Oct 22, 2025 •
edited
Loading

Also, updating arjun-cnf to 2.6.1 comes with higher cmake version bound already but that can be done in a separate PR, but maybe leave a comment to remove the flag after update

@Sigmanificient Sigmanificient mentioned this pull request Oct 22, 2025
Open
@iedame
Copy link
Contributor Author

iedame commented Oct 22, 2025

It won't fail if upstream updates the minimum required version, so using substituteInPlace is preferred.

I am doing many of those cmake4 fixes so if I skipped updating the package it is probably because it wasn't a quick update.

You are welcome to open a PR with the update and rebase after this is merged or I can simply remove the patches for it. I am okay with either approach.

@t4ccer
Copy link
Member

t4ccer commented Oct 22, 2025

Yeah ok, lets get this merged and I'll do the update when I'll find some spare time

@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels Oct 22, 2025
@Sigmanificient Sigmanificient added this pull request to the merge queue Oct 23, 2025
Merged via the queue into NixOS:master with commit 730ddde Oct 23, 2025
31 of 34 checks passed
@iedame iedame deleted the cmake4/louvain-community branch October 23, 2025 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@t4ccer t4ccer t4ccer approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Build failure: approxmc Build failure: arjun-cnf

3 participants

@iedame @t4ccer @Sigmanificient