Skip to content

lolcode: fix build with cmake4#454502

Merged
Sigmanificient merged 1 commit intoNixOS:masterfrom
iedame:cmake4/lolcode
Oct 31, 2025
Merged

lolcode: fix build with cmake4#454502
Sigmanificient merged 1 commit intoNixOS:masterfrom
iedame:cmake4/lolcode

Conversation

@iedame
Copy link
Contributor

@iedame iedame commented Oct 22, 2025

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 9.needs: reviewer This PR currently has no reviewers requested and needs attention. labels Oct 22, 2025
@iedame
Copy link
Contributor Author

iedame commented Oct 22, 2025

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 454502
Commit: 659c110a60624f7fe53615e45a8f66da9c5346c2 (subsequent changes)
Merge: 6e38048eefc986a24be5c7a2693dd37f61426ea4

Logs: https://github.com/iedame/nixpkgs-review-gha/actions/runs/18713027410


x86_64-linux

✅ 1 package built:
  • lolcode

aarch64-linux

✅ 1 package built:
  • lolcode

x86_64-darwin (sandbox = true)

✅ 1 package built:
  • lolcode

aarch64-darwin (sandbox = true)

✅ 1 package built:
  • lolcode

Copy link
Member

@mdaniels5757 mdaniels5757 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diff and nixpkgs-review LGTM.

@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 1 This PR was reviewed and approved by one person. and removed 9.needs: reviewer This PR currently has no reviewers requested and needs attention. labels Oct 24, 2025
@Sigmanificient
Copy link
Member

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 454502
Commit: 0f4e226176b329b0e49c87a2cbe22482350d1486 (subsequent changes)
Merge: e40554586a097d84d0e1d99efd4b84f2cb305dbe

Logs: https://github.com/Sigmanificient/nixpkgs-review-gha/actions/runs/18987159980


x86_64-linux

✅ 1 package built:
  • lolcode

aarch64-linux

✅ 1 package built:
  • lolcode

x86_64-darwin (sandbox = true)

✅ 1 package built:
  • lolcode

aarch64-darwin (sandbox = true)

✅ 1 package built:
  • lolcode

@Sigmanificient Sigmanificient added this pull request to the merge queue Oct 31, 2025
@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 2 This PR was reviewed and approved by two persons. and removed 12.approvals: 1 This PR was reviewed and approved by one person. labels Oct 31, 2025
Merged via the queue into NixOS:master with commit 90eb179 Oct 31, 2025
29 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 2 This PR was reviewed and approved by two persons.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants