Skip to content

lobster: fix build with cmake4#454393

Merged
fgaz merged 1 commit intoNixOS:masterfrom
iedame:cmake4/lobster
Oct 25, 2025
Merged

lobster: fix build with cmake4#454393
fgaz merged 1 commit intoNixOS:masterfrom
iedame:cmake4/lobster

Conversation

@iedame
Copy link
Contributor

@iedame iedame commented Oct 21, 2025

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Oct 21, 2025
@nix-owners nix-owners bot requested a review from fgaz October 21, 2025 23:49
@nixpkgs-ci nixpkgs-ci bot added the 9.needs: reviewer This PR currently has no reviewers requested and needs attention. label Oct 21, 2025
@iedame
Copy link
Contributor Author

iedame commented Oct 21, 2025

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 454393
Commit: a4d2b357132258b504438810a8df30a340cf9827 (subsequent changes)
Merge: ffd567dfca2587ca231b66ad58d620ee8b42c70a

Logs: https://github.com/iedame/nixpkgs-review-gha/actions/runs/18700875216


x86_64-linux

✅ 1 package built:
  • lobster

aarch64-linux

✅ 1 package built:
  • lobster

x86_64-darwin

No rebuilds


aarch64-darwin

No rebuilds

@nixpkgs-ci nixpkgs-ci bot removed the 9.needs: reviewer This PR currently has no reviewers requested and needs attention. label Oct 22, 2025
Copy link
Member

@fgaz fgaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please apply aardappel/lobster@a5f46ed instead (see "How to fix broken packages" in #445447)

@iedame
Copy link
Contributor Author

iedame commented Oct 25, 2025

@fgaz Thank you for linking the patch! I have applied it, please take a look.

@iedame
Copy link
Contributor Author

iedame commented Oct 25, 2025

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 454393
Commit: cdd27b6057223d6899fa6bab589845da9d85e448 (subsequent changes)
Merge: 3e1f183a52d7b5c92804cffc3dd28335fefa6133

Logs: https://github.com/iedame/nixpkgs-review-gha/actions/runs/18803747340


x86_64-linux

✅ 1 package built:
  • lobster

aarch64-linux

✅ 1 package built:
  • lobster

x86_64-darwin

No rebuilds


aarch64-darwin

No rebuilds

Copy link
Member

@fgaz fgaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@fgaz fgaz added this pull request to the merge queue Oct 25, 2025
Merged via the queue into NixOS:master with commit 3d3d951 Oct 25, 2025
26 of 30 checks passed
@iedame iedame deleted the cmake4/lobster branch October 25, 2025 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants