Skip to content

libwebcam: fix build with cmake4#454379

Merged
Aleksanaa merged 1 commit intoNixOS:masterfrom
iedame:cmake4/libwebcam
Nov 8, 2025
Merged

libwebcam: fix build with cmake4#454379
Aleksanaa merged 1 commit intoNixOS:masterfrom
iedame:cmake4/libwebcam

Conversation

@iedame
Copy link
Contributor

@iedame iedame commented Oct 21, 2025

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Oct 21, 2025
@nix-owners nix-owners bot requested a review from jraygauthier October 21, 2025 22:50
@iedame
Copy link
Contributor Author

iedame commented Oct 21, 2025

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 454379
Commit: 001f5c9c5953bba44bc5d222d9da760eaff5f43d (subsequent changes)
Merge: edc23fc6cf71744499b915bb2cac09f72628d770

Logs: https://github.com/iedame/nixpkgs-review-gha/actions/runs/18700818336


x86_64-linux

✅ 1 package built:
  • libwebcam

aarch64-linux

✅ 1 package built:
  • libwebcam

x86_64-darwin

No rebuilds


aarch64-darwin

No rebuilds

@iedame iedame added the 0.kind: ZHF Fixes Fixes during the Zero Hydra Failures (ZHF) campaign label Nov 3, 2025
Copy link
Contributor

@magicquark magicquark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diff LGTM.

@nixpkgs-ci nixpkgs-ci bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Nov 7, 2025
@booxter
Copy link
Contributor

booxter commented Nov 8, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 454379
Commit: 001f5c9c5953bba44bc5d222d9da760eaff5f43d


x86_64-linux

✅ 1 package built:
  • libwebcam

aarch64-linux

✅ 1 package built:
  • libwebcam

Copy link
Contributor

@booxter booxter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved automatically following the successful run of nixpkgs-review.

@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 2 This PR was reviewed and approved by two persons. and removed 12.approvals: 1 This PR was reviewed and approved by one person. labels Nov 8, 2025
@Aleksanaa Aleksanaa added this pull request to the merge queue Nov 8, 2025
Merged via the queue into NixOS:master with commit b44706a Nov 8, 2025
37 of 38 checks passed
@iedame iedame deleted the cmake4/libwebcam branch November 8, 2025 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0.kind: ZHF Fixes Fixes during the Zero Hydra Failures (ZHF) campaign 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 2 This PR was reviewed and approved by two persons.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants