Skip to content

librepcb: fix build with cmake4#454370

Merged
Sigmanificient merged 1 commit intoNixOS:masterfrom
iedame:cmake4/librepcb
Oct 30, 2025
Merged

librepcb: fix build with cmake4#454370
Sigmanificient merged 1 commit intoNixOS:masterfrom
iedame:cmake4/librepcb

Conversation

@iedame
Copy link
Contributor

@iedame iedame commented Oct 21, 2025

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Oct 21, 2025
@nix-owners nix-owners bot requested review from Luz and thoughtpolice October 21, 2025 22:23
@nixpkgs-ci nixpkgs-ci bot added 9.needs: reviewer This PR currently has no reviewers requested and needs attention. and removed 9.needs: reviewer This PR currently has no reviewers requested and needs attention. labels Oct 21, 2025
@iedame

This comment was marked as outdated.

Sign in to view
@Sigmanificient Sigmanificient mentioned this pull request Oct 22, 2025
Open
@iedame
Copy link
Contributor Author

iedame commented Oct 27, 2025

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 454370
Commit: e6225a8eb3c2e8cc3f08155d6a7be7b9cb01f609 (subsequent changes)
Merge: bc3534bf807e22911fea75d3ec6c09777cb5858a

Logs: https://github.com/iedame/nixpkgs-review-gha/actions/runs/18826587411

x86_64-linux

✅ 1 package built:
  • librepcb

aarch64-linux

✅ 1 package built:
  • librepcb

x86_64-darwin

✅ No rebuilds

aarch64-darwin

✅ No rebuilds

Luz
Luz approved these changes Oct 29, 2025
View reviewed changes
Copy link
Member

@Luz Luz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels Oct 29, 2025
@Sigmanificient Sigmanificient added this pull request to the merge queue Oct 30, 2025
Merged via the queue into NixOS:master with commit ad60340 Oct 30, 2025
30 of 32 checks passed
@iedame iedame deleted the cmake4/librepcb branch October 30, 2025 01:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thoughtpolice thoughtpolice Awaiting requested review from thoughtpolice

1 more reviewer

@Luz Luz Luz approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@iedame @Luz @Sigmanificient