Skip to content

libnghttp2_asio: fix build with cmake4#454316

Merged
Aleksanaa merged 1 commit intoNixOS:masterfrom
iedame:cmake4/libnghttp2_asio
Nov 8, 2025
Merged

libnghttp2_asio: fix build with cmake4#454316
Aleksanaa merged 1 commit intoNixOS:masterfrom
iedame:cmake4/libnghttp2_asio

Conversation

@iedame
Copy link
Contributor

@iedame iedame commented Oct 21, 2025

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Oct 21, 2025
@nix-owners nix-owners bot requested a review from Izorkin October 21, 2025 19:47
@iedame
Copy link
Contributor Author

iedame commented Oct 21, 2025

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 454316
Commit: 345a318c5a533eac2d6cddddb40623429c2f286d (subsequent changes)
Merge: cc951ce5892a1f99142fe451051ec1d7090e435e

Logs: https://github.com/iedame/nixpkgs-review-gha/actions/runs/18696648776


x86_64-linux

✅ 3 packages built:
  • libnghttp2_asio
  • libnghttp2_asio.dev
  • libnghttp2_asio.doc

aarch64-linux

✅ 3 packages built:
  • libnghttp2_asio
  • libnghttp2_asio.dev
  • libnghttp2_asio.doc

x86_64-darwin (sandbox = true)

✅ 3 packages built:
  • libnghttp2_asio
  • libnghttp2_asio.dev
  • libnghttp2_asio.doc

aarch64-darwin (sandbox = true)

✅ 3 packages built:
  • libnghttp2_asio
  • libnghttp2_asio.dev
  • libnghttp2_asio.doc

@iedame iedame added the 0.kind: ZHF Fixes Fixes during the Zero Hydra Failures (ZHF) campaign label Nov 3, 2025
@booxter
Copy link
Contributor

booxter commented Nov 5, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 454316
Commit: 345a318c5a533eac2d6cddddb40623429c2f286d


x86_64-linux

✅ 3 packages built:
  • libnghttp2_asio
  • libnghttp2_asio.dev
  • libnghttp2_asio.doc

aarch64-linux

✅ 3 packages built:
  • libnghttp2_asio
  • libnghttp2_asio.dev
  • libnghttp2_asio.doc

x86_64-darwin

✅ 3 packages built:
  • libnghttp2_asio
  • libnghttp2_asio.dev
  • libnghttp2_asio.doc

aarch64-darwin

✅ 3 packages built:
  • libnghttp2_asio
  • libnghttp2_asio.dev
  • libnghttp2_asio.doc

Copy link
Contributor

@booxter booxter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved automatically following the successful run of nixpkgs-review.

@nixpkgs-ci nixpkgs-ci bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Nov 5, 2025
@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 2 This PR was reviewed and approved by two persons. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. and removed 12.approvals: 1 This PR was reviewed and approved by one person. labels Nov 7, 2025
@iedame iedame requested a review from Sigmanificient November 8, 2025 05:48
@Aleksanaa Aleksanaa added this pull request to the merge queue Nov 8, 2025
Merged via the queue into NixOS:master with commit cfbf79b Nov 8, 2025
39 of 40 checks passed
@iedame iedame deleted the cmake4/libnghttp2_asio branch November 8, 2025 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0.kind: ZHF Fixes Fixes during the Zero Hydra Failures (ZHF) campaign 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 2 This PR was reviewed and approved by two persons. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants