Skip to content

liblaxjson: fix build with cmake4#454315

Merged
Aleksanaa merged 1 commit intoNixOS:masterfrom
iedame:cmake4/liblaxjson
Nov 8, 2025
Merged

liblaxjson: fix build with cmake4#454315
Aleksanaa merged 1 commit intoNixOS:masterfrom
iedame:cmake4/liblaxjson

Conversation

@iedame
Copy link
Contributor

@iedame iedame commented Oct 21, 2025

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Oct 21, 2025
@nix-owners nix-owners bot requested a review from andrewrk October 21, 2025 19:42
@iedame

This comment was marked as outdated.

@iedame iedame force-pushed the cmake4/liblaxjson branch from 90579ca to 4c86df0 Compare October 21, 2025 20:37
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. and removed 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. labels Oct 21, 2025
@iedame
Copy link
Contributor Author

iedame commented Oct 21, 2025

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 454315
Commit: 4c86df0733883f84e9cd22aea9dfe29a67a9cf73 (subsequent changes)
Merge: 29b43b19954c1462a82e0dd36c221ffa52d8e5b7

Logs: https://github.com/iedame/nixpkgs-review-gha/actions/runs/18697045126


x86_64-linux

✅ 1 package built:
  • liblaxjson

aarch64-linux

✅ 1 package built:
  • liblaxjson

x86_64-darwin

No rebuilds


aarch64-darwin

No rebuilds

@iedame iedame added the 0.kind: ZHF Fixes Fixes during the Zero Hydra Failures (ZHF) campaign label Nov 3, 2025
Copy link
Contributor

@booxter booxter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder, a bit, if this library is actually used anywhere. The upstream repo wasn't touched for ages, and we don't have any dependencies in-tree.

@nixpkgs-ci nixpkgs-ci bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Nov 5, 2025
@Aleksanaa Aleksanaa added this pull request to the merge queue Nov 8, 2025
Merged via the queue into NixOS:master with commit 460c558 Nov 8, 2025
33 of 34 checks passed
@iedame iedame deleted the cmake4/liblaxjson branch November 8, 2025 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0.kind: ZHF Fixes Fixes during the Zero Hydra Failures (ZHF) campaign 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants