Skip to content

libjson-rpc-cpp: fix build with cmake4#454311

Merged
Sigmanificient merged 1 commit intoNixOS:masterfrom
iedame:cmake4/libjson-rpc-cpp
Oct 23, 2025
Merged

libjson-rpc-cpp: fix build with cmake4#454311
Sigmanificient merged 1 commit intoNixOS:masterfrom
iedame:cmake4/libjson-rpc-cpp

Conversation

@iedame
Copy link
Contributor

@iedame iedame commented Oct 21, 2025

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Oct 21, 2025
@nix-owners nix-owners bot requested a review from judgeNotFound October 21, 2025 19:34
@iedame
Copy link
Contributor Author

iedame commented Oct 21, 2025

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 454311
Commit: 6e46b015a4307017cc5eb21edcac9666cdd004b3 (subsequent changes)
Merge: 75aa627785a160f24ab3f4ad3d6435b8df937456

Logs: https://github.com/iedame/nixpkgs-review-gha/actions/runs/18695402748

x86_64-linux

✅ 1 package built:
  • libjson-rpc-cpp

aarch64-linux

✅ 1 package built:
  • libjson-rpc-cpp

x86_64-darwin

✅ No rebuilds

aarch64-darwin

✅ No rebuilds

@dotlambda dotlambda mentioned this pull request Oct 21, 2025
Open
@judgeNotFound
Copy link
Contributor

judgeNotFound commented Oct 23, 2025 •
edited
Loading

@NixOS/nixpkgs-merge-bot merge

@nixpkgs-merge-bot
Copy link
Contributor

nixpkgs-merge-bot bot commented Oct 23, 2025

@judgeNotFound merge not permitted (#305350):
R-Ryantm Maintainer merge: pr author is not r-ryantm
CommitterPR: pr author is not committer

@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels Oct 23, 2025
@Sigmanificient Sigmanificient added this pull request to the merge queue Oct 23, 2025
Merged via the queue into NixOS:master with commit c35d121 Oct 23, 2025
32 of 35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@judgeNotFound judgeNotFound judgeNotFound approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@iedame @judgeNotFound @Sigmanificient