Skip to content

knightos-{genkfs, kcc, kimg, kpack, mktiupgrade, patchrom, scas, z80e}: fix…#454262

Merged
siraben merged 2 commits intoNixOS:masterfrom
iedame:cmake4/knightos
Oct 21, 2025
Merged

knightos-{genkfs, kcc, kimg, kpack, mktiupgrade, patchrom, scas, z80e}: fix…#454262
siraben merged 2 commits intoNixOS:masterfrom
iedame:cmake4/knightos

Conversation

@iedame
Copy link
Contributor

@iedame iedame commented Oct 21, 2025

… build with cmake4

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. labels Oct 21, 2025
@nix-owners nix-owners bot requested a review from siraben October 21, 2025 16:55
@iedame

This comment was marked as outdated.

@iedame
Copy link
Contributor Author

iedame commented Oct 21, 2025

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 454262
Commit: 3e1bcc81ec7a97997e4c3502d0f1a1687e052a07 (subsequent changes)
Merge: d9a9efd720776e5f13c1c253e4ad987482850d04

Logs: https://github.com/iedame/nixpkgs-review-gha/actions/runs/18692819187


x86_64-linux

✅ 8 packages built:
  • knightos-genkfs
  • knightos-kcc
  • knightos-kimg
  • knightos-kpack
  • knightos-mktiupgrade
  • knightos-patchrom
  • knightos-scas
  • knightos-z80e

aarch64-linux

✅ 8 packages built:
  • knightos-genkfs
  • knightos-kcc
  • knightos-kimg
  • knightos-kpack
  • knightos-mktiupgrade
  • knightos-patchrom
  • knightos-scas
  • knightos-z80e

x86_64-darwin (sandbox = true)

✅ 8 packages built:
  • knightos-genkfs
  • knightos-kcc
  • knightos-kimg
  • knightos-kpack
  • knightos-mktiupgrade
  • knightos-patchrom
  • knightos-scas
  • knightos-z80e

aarch64-darwin (sandbox = true)

✅ 8 packages built:
  • knightos-genkfs
  • knightos-kcc
  • knightos-kimg
  • knightos-kpack
  • knightos-mktiupgrade
  • knightos-patchrom
  • knightos-scas
  • knightos-z80e

@iedame
Copy link
Contributor Author

iedame commented Oct 21, 2025

@Sigmanificient this one wasn't in the list: knightos-z80e, added here and fixed.

@iedame iedame changed the title knightos-{genkfs, kcc, kimg, kpack, mktiupgrade, patchrom, scas}: fix… knightos-{genkfs, kcc, kimg, kpack, mktiupgrade, patchrom, scas, z80e}: fix… Oct 21, 2025
@siraben
Copy link
Member

siraben commented Oct 21, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 454262
Commit: a8c190adbd7cff5bcc2794875305848536c7f6d4


x86_64-linux

✅ 8 packages built:
  • knightos-genkfs
  • knightos-kcc
  • knightos-kimg
  • knightos-kpack
  • knightos-mktiupgrade
  • knightos-patchrom
  • knightos-scas
  • knightos-z80e

@siraben siraben added this pull request to the merge queue Oct 21, 2025
@siraben
Copy link
Member

siraben commented Oct 21, 2025

Thanks for doing this!

Merged via the queue into NixOS:master with commit 2b73222 Oct 21, 2025
27 of 31 checks passed
@iedame iedame deleted the cmake4/knightos branch October 21, 2025 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants