Skip to content

ispike: fix build with cmake4#454221

Merged
SuperSandro2000 merged 1 commit intoNixOS:masterfrom
iedame:cmake4/ispike
Oct 21, 2025
Merged

ispike: fix build with cmake4#454221
SuperSandro2000 merged 1 commit intoNixOS:masterfrom
iedame:cmake4/ispike

Conversation

@iedame
Copy link
Contributor

@iedame iedame commented Oct 21, 2025

Fails to build with latest boost, so I switched to latest supported.

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Oct 21, 2025
@nix-owners nix-owners bot requested a review from nico202 October 21, 2025 14:43
@Sigmanificient Sigmanificient mentioned this pull request Oct 21, 2025
Open
@nixpkgs-ci nixpkgs-ci bot added 9.needs: reviewer This PR currently has no reviewers requested and needs attention. and removed 9.needs: reviewer This PR currently has no reviewers requested and needs attention. labels Oct 21, 2025
@iedame
Copy link
Contributor Author

iedame commented Oct 21, 2025

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 454221
Commit: e39a45fb2e594077d039466f6fb2852354b4603e (subsequent changes)
Merge: b7ea48cf39579b03312534b46f35c787ecd24e2a

Logs: https://github.com/iedame/nixpkgs-review-gha/actions/runs/18687860477

x86_64-linux

✅ 1 package built:
  • ispike

aarch64-linux

✅ 1 package built:
  • ispike

x86_64-darwin (sandbox = true)

✅ 1 package built:
  • ispike

aarch64-darwin (sandbox = true)

✅ 1 package built:
  • ispike

@SuperSandro2000 SuperSandro2000 added this pull request to the merge queue Oct 21, 2025
Merged via the queue into NixOS:master with commit 600a071 Oct 21, 2025
31 of 35 checks passed
@iedame iedame deleted the cmake4/ispike branch October 21, 2025 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nico202 nico202 Awaiting requested review from nico202

Assignees

No one assigned

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@iedame @SuperSandro2000