nixos/dhcpcd: Wait for devices to settle, unblock nixos-unstable#45421
Merged
globin merged 1 commit intoNixOS:masterfrom Aug 21, 2018
Merged
nixos/dhcpcd: Wait for devices to settle, unblock nixos-unstable#45421globin merged 1 commit intoNixOS:masterfrom
globin merged 1 commit intoNixOS:masterfrom
Conversation
Member
|
Also see #39329 which was opened when we hat this issue with networkd. Also maybe |
5f1b906 to
184d3cd
Compare
Contributor
Author
|
@globin Ah, yes, that makes sense. Thanks. :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for this change
This works around #45346 and removes the channel blocker on unstable by waiting for the devices to settle via udevadm. This is needed to avoid a race condition where dhcpcd grabs the interface before predictable interface renaming is done after dhcpcd was moved to before
networking.targetin #44524I still feel that it seems more logical that dhcpcd should be after
networking.target(all interfaces are ready and renamed,) but since that is not desired (per the discussion in the aforementioned issue,) this should work.Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)