Skip to content

imagelol: fix build with cmake4, mark as broken on darwin#454208

Merged
SigmaSquadron merged 1 commit intoNixOS:masterfrom
iedame:cmake4/imagelol
Oct 22, 2025
Merged

imagelol: fix build with cmake4, mark as broken on darwin#454208
SigmaSquadron merged 1 commit intoNixOS:masterfrom
iedame:cmake4/imagelol

Conversation

@iedame
Copy link
Contributor

@iedame iedame commented Oct 21, 2025 •
edited
Loading

Marking as broken on darwin, it hasn't built on Darwin since January

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 9.needs: reviewer This PR currently has no reviewers requested and needs attention. labels Oct 21, 2025
@iedame

This comment was marked as outdated.

Sign in to view
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. and removed 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. labels Oct 21, 2025
@iedame
Copy link
Contributor Author

iedame commented Oct 21, 2025

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 454208
Commit: efb89bdc1c516d42df3a59cc4c2bcf2a2a78e513 (subsequent changes)
Merge: 5112bffef7f75a41941c4a8ec86de00383573aaf

Logs: https://github.com/iedame/nixpkgs-review-gha/actions/runs/18686948519

x86_64-linux

✅ 1 package built:
  • imagelol

aarch64-linux

✅ 1 package built:
  • imagelol

x86_64-darwin

✅ No rebuilds

aarch64-darwin

✅ No rebuilds

@siraben
Copy link
Member

siraben commented Oct 22, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 454208
Commit: efb89bdc1c516d42df3a59cc4c2bcf2a2a78e513

x86_64-linux

✅ 1 package built:
  • imagelol

mdaniels5757
mdaniels5757 approved these changes Oct 22, 2025
View reviewed changes
Copy link
Member

@mdaniels5757 mdaniels5757 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diff and nixpkgs-review LGTM. The marking as broken on Darwin seems correct (it hasn't built on Darwin since January), but ideally the commit message would mention that.

@iedame iedame changed the title imagelol: fix build with cmake4 imagelol: fix build with cmake4, mark as broken on darwin Oct 22, 2025
@iedame
Copy link
Contributor Author

iedame commented Oct 22, 2025

Diff and nixpkgs-review LGTM. The marking as broken on Darwin seems correct (it hasn't built on Darwin since January), but ideally the commit message would mention that.

Thank you for the feedback! I added it to the commit message and PR title.

@nixpkgs-ci nixpkgs-ci bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Oct 22, 2025
@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Oct 22, 2025
@nixpkgs-ci nixpkgs-ci bot removed the 9.needs: reviewer This PR currently has no reviewers requested and needs attention. label Oct 22, 2025
@siraben siraben mentioned this pull request Oct 22, 2025
Merged
13 tasks
@iedame
Copy link
Contributor Author

iedame commented Oct 22, 2025

Final force-push was to add @mdaniels5757 as co-author.

@SigmaSquadron SigmaSquadron added this pull request to the merge queue Oct 22, 2025
Merged via the queue into NixOS:master with commit 7c9ab72 Oct 22, 2025
26 of 30 checks passed
@iedame iedame deleted the cmake4/imagelol branch October 22, 2025 09:52
@Sigmanificient Sigmanificient mentioned this pull request Oct 22, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mdaniels5757 mdaniels5757 mdaniels5757 approved these changes

Assignees

No one assigned

Labels

6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@iedame @siraben @mdaniels5757 @SigmaSquadron