Skip to content

http-getter: fix build with cmake4#454200

Merged
Sigmanificient merged 1 commit intoNixOS:masterfrom
iedame:cmake4/http-getter
Oct 31, 2025
Merged

http-getter: fix build with cmake4#454200
Sigmanificient merged 1 commit intoNixOS:masterfrom
iedame:cmake4/http-getter

Conversation

@iedame
Copy link
Contributor

@iedame iedame commented Oct 21, 2025

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Oct 21, 2025
@iedame
Copy link
Contributor Author

iedame commented Oct 21, 2025

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 454200
Commit: fb95ae72677f9b6bfeb4553fd19daa903a513d0f (subsequent changes)
Merge: 16575a4f7490a8c31b39ad30d68e129414e5e52a

Logs: https://github.com/iedame/nixpkgs-review-gha/actions/runs/18685461866

x86_64-linux

✅ 1 package built:
  • http-getter

aarch64-linux

✅ 1 package built:
  • http-getter

x86_64-darwin (sandbox = true)

✅ 1 package built:
  • http-getter

aarch64-darwin (sandbox = true)

✅ 1 package built:
  • http-getter

@nixpkgs-ci nixpkgs-ci bot added the 9.needs: reviewer This PR currently has no reviewers requested and needs attention. label Oct 21, 2025
mdaniels5757
mdaniels5757 approved these changes Oct 22, 2025
View reviewed changes
Copy link
Member

@mdaniels5757 mdaniels5757 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diff and nixpkgs-review LGTM. (I see upstream didn't upgrade past 3.5, but I don't think that's worth not using their patch over, especially given that it contains another change to remove the use of a deprecated cURL function.)

@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 1 This PR was reviewed and approved by one person. and removed 9.needs: reviewer This PR currently has no reviewers requested and needs attention. labels Oct 22, 2025
@Sigmanificient Sigmanificient mentioned this pull request Oct 22, 2025
Open
Sigmanificient
Sigmanificient requested changes Oct 26, 2025
View reviewed changes
@iedame iedame force-pushed the cmake4/http-getter branch from fb95ae7 to 15cf89d Compare October 26, 2025 04:59
@Sigmanificient
Copy link
Member

Sigmanificient commented Oct 31, 2025

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 454200
Commit: 15cf89dd7a2f3c044a6d2f049b73170b4ba5f913 (subsequent changes)
Merge: 4495d75b6f4562661957933b95ea4dd148f21af1

Logs: https://github.com/Sigmanificient/nixpkgs-review-gha/actions/runs/18987161768

x86_64-linux

✅ 1 package built:
  • http-getter

aarch64-linux

✅ 1 package built:
  • http-getter

x86_64-darwin (sandbox = true)

✅ 1 package built:
  • http-getter

aarch64-darwin (sandbox = true)

✅ 1 package built:
  • http-getter

@Sigmanificient Sigmanificient added this pull request to the merge queue Oct 31, 2025
Merged via the queue into NixOS:master with commit 070937c Oct 31, 2025
28 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mdaniels5757 mdaniels5757 mdaniels5757 approved these changes

@Sigmanificient Sigmanificient Sigmanificient approved these changes

Assignees

No one assigned

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@iedame @Sigmanificient @mdaniels5757