Skip to content

teamviewer v9#4542

Closed
shdpl wants to merge 1 commit intoNixOS:masterfrom
shdpl:teamviewer
Closed

teamviewer v9#4542
shdpl wants to merge 1 commit intoNixOS:masterfrom
shdpl:teamviewer

Conversation

@shdpl
Copy link
Contributor

@shdpl shdpl commented Oct 15, 2014

No description provided.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hash will change with every new teamviewer update :(

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, my work is just copy-paste of version 8 with replacing it with 9.
It works. I know it could be better but i figured i'll make pull request so others wont have to do manual work which i did.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you do something similar to pkgs/games/planetaryannihilation/default.nix? So user has to set the download url

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding possibility to override hash and url while retaining default one seems really good idea.
I'll try to add it when i'll have at least a little bit of time.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, thanks! Then we should do the same for versions 7 and 8.

@domenkozar domenkozar added 9.needs: reporter feedback This issue needs the person who filed it to respond work-in-progress and removed 9.needs: reporter feedback This issue needs the person who filed it to respond labels Oct 23, 2014
@aristidb
Copy link
Contributor

Updated SHA256 and merged manually. Can somebody tell me how to actually use this though? It complains about a missing daemon...

@aristidb aristidb closed this Oct 25, 2014
@domenkozar
Copy link
Member

This shouldn't have been merged. Hash will change on every update, leaving a poor UX. See my comment above.

@shdpl
Copy link
Contributor Author

shdpl commented Oct 30, 2014

It's the same as 8.nix which means you need to run teamviewerd as root before using client as normal user.

How do i make changes when the branch is closed? Shall i open a new one?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

12.first-time contribution This PR is the author's first one; please be gentle!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants