Skip to content

h3, h3_3: fix build with cmake4#454194

Merged
SigmaSquadron merged 1 commit intoNixOS:masterfrom
iedame:cmake4/h3
Oct 31, 2025
Merged

h3, h3_3: fix build with cmake4#454194
SigmaSquadron merged 1 commit intoNixOS:masterfrom
iedame:cmake4/h3

Conversation

@iedame
Copy link
Contributor

@iedame iedame commented Oct 21, 2025

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. labels Oct 21, 2025
@nix-owners nix-owners bot requested a review from kalbasit October 21, 2025 12:56
@nixpkgs-ci nixpkgs-ci bot added the 9.needs: reviewer This PR currently has no reviewers requested and needs attention. label Oct 21, 2025
@Sigmanificient Sigmanificient mentioned this pull request Oct 21, 2025
Open
@iedame
Copy link
Contributor Author

iedame commented Oct 21, 2025

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 454194
Commit: 43fcec5186ca28285f480aa692b35664fd640f56 (subsequent changes)
Merge: 14896706077197f5f1cde34abe2f2a632b93c1e7

Logs: https://github.com/iedame/nixpkgs-review-gha/actions/runs/18684460087

x86_64-linux

❌ 4 packages failed to build:
  • python312Packages.timezonefinder
  • python312Packages.timezonefinder.dist
  • python313Packages.timezonefinder
  • python313Packages.timezonefinder.dist
✅ 14 packages built:
  • h3 (h3_3)
  • h3.dev (h3_3.dev)
  • h3_4
  • h3_4.dev
  • postgresql13Packages.h3-pg
  • postgresql14Packages.h3-pg
  • postgresql15Packages.h3-pg
  • postgresql16Packages.h3-pg
  • postgresqlPackages.h3-pg (postgresql17Packages.h3-pg)
  • postgresql18Packages.h3-pg
  • python312Packages.h3
  • python312Packages.h3.dist
  • python313Packages.h3
  • python313Packages.h3.dist
Error logs: `x86_64-linux`
python312Packages.timezonefinder 
adding 'timezonefinder/flatbuf/shortcut_schema.fbs'
adding 'timezonefinder/flatbuf/shortcut_utils.py'
adding 'timezonefinder/inside_poly_extension/inside_polygon_int.c'
adding 'timezonefinder/inside_poly_extension/inside_polygon_int.h'
adding 'timezonefinder-8.0.0.data/data/DATA_LICENSE'
adding 'timezonefinder-8.0.0.dist-info/licenses/LICENSE'
adding 'timezonefinder-8.0.0.dist-info/METADATA'
adding 'timezonefinder-8.0.0.dist-info/WHEEL'
adding 'timezonefinder-8.0.0.dist-info/entry_points.txt'
adding 'timezonefinder-8.0.0.dist-info/top_level.txt'
adding 'timezonefinder-8.0.0.dist-info/RECORD'
removing build/bdist.linux-x86_64/wheel
Successfully built timezonefinder-8.0.0-cp312-cp312-linux_x86_64.whl
Finished creating a wheel...
Finished executing pypaBuildPhase
Running phase: pythonRuntimeDepsCheckHook
@nix { "action": "setPhase", "phase": "pythonRuntimeDepsCheckHook" }
Executing pythonRuntimeDepsCheck
Checking runtime dependencies for timezonefinder-8.0.0-cp312-cp312-linux_x86_64.whl
  - cffi<2,>=1.15.1 not satisfied by version 2.0.0
python313Packages.timezonefinder 
adding 'timezonefinder/flatbuf/shortcut_schema.fbs'
adding 'timezonefinder/flatbuf/shortcut_utils.py'
adding 'timezonefinder/inside_poly_extension/inside_polygon_int.c'
adding 'timezonefinder/inside_poly_extension/inside_polygon_int.h'
adding 'timezonefinder-8.0.0.data/data/DATA_LICENSE'
adding 'timezonefinder-8.0.0.dist-info/licenses/LICENSE'
adding 'timezonefinder-8.0.0.dist-info/METADATA'
adding 'timezonefinder-8.0.0.dist-info/WHEEL'
adding 'timezonefinder-8.0.0.dist-info/entry_points.txt'
adding 'timezonefinder-8.0.0.dist-info/top_level.txt'
adding 'timezonefinder-8.0.0.dist-info/RECORD'
removing build/bdist.linux-x86_64/wheel
Successfully built timezonefinder-8.0.0-cp313-cp313-linux_x86_64.whl
Finished creating a wheel...
Finished executing pypaBuildPhase
Running phase: pythonRuntimeDepsCheckHook
@nix { "action": "setPhase", "phase": "pythonRuntimeDepsCheckHook" }
Executing pythonRuntimeDepsCheck
Checking runtime dependencies for timezonefinder-8.0.0-cp313-cp313-linux_x86_64.whl
  - cffi<2,>=1.15.1 not satisfied by version 2.0.0

aarch64-linux

❌ 4 packages failed to build:
  • python312Packages.timezonefinder
  • python312Packages.timezonefinder.dist
  • python313Packages.timezonefinder
  • python313Packages.timezonefinder.dist
✅ 14 packages built:
  • h3 (h3_3)
  • h3.dev (h3_3.dev)
  • h3_4
  • h3_4.dev
  • postgresql13Packages.h3-pg
  • postgresql14Packages.h3-pg
  • postgresql15Packages.h3-pg
  • postgresql16Packages.h3-pg
  • postgresqlPackages.h3-pg (postgresql17Packages.h3-pg)
  • postgresql18Packages.h3-pg
  • python312Packages.h3
  • python312Packages.h3.dist
  • python313Packages.h3
  • python313Packages.h3.dist
Error logs: `aarch64-linux`
python312Packages.timezonefinder 
adding 'timezonefinder/flatbuf/shortcut_schema.fbs'
adding 'timezonefinder/flatbuf/shortcut_utils.py'
adding 'timezonefinder/inside_poly_extension/inside_polygon_int.c'
adding 'timezonefinder/inside_poly_extension/inside_polygon_int.h'
adding 'timezonefinder-8.0.0.data/data/DATA_LICENSE'
adding 'timezonefinder-8.0.0.dist-info/licenses/LICENSE'
adding 'timezonefinder-8.0.0.dist-info/METADATA'
adding 'timezonefinder-8.0.0.dist-info/WHEEL'
adding 'timezonefinder-8.0.0.dist-info/entry_points.txt'
adding 'timezonefinder-8.0.0.dist-info/top_level.txt'
adding 'timezonefinder-8.0.0.dist-info/RECORD'
removing build/bdist.linux-aarch64/wheel
Successfully built timezonefinder-8.0.0-cp312-cp312-linux_aarch64.whl
Finished creating a wheel...
Finished executing pypaBuildPhase
Running phase: pythonRuntimeDepsCheckHook
@nix { "action": "setPhase", "phase": "pythonRuntimeDepsCheckHook" }
Executing pythonRuntimeDepsCheck
Checking runtime dependencies for timezonefinder-8.0.0-cp312-cp312-linux_aarch64.whl
  - cffi<2,>=1.15.1 not satisfied by version 2.0.0
python313Packages.timezonefinder 
adding 'timezonefinder/flatbuf/shortcut_schema.fbs'
adding 'timezonefinder/flatbuf/shortcut_utils.py'
adding 'timezonefinder/inside_poly_extension/inside_polygon_int.c'
adding 'timezonefinder/inside_poly_extension/inside_polygon_int.h'
adding 'timezonefinder-8.0.0.data/data/DATA_LICENSE'
adding 'timezonefinder-8.0.0.dist-info/licenses/LICENSE'
adding 'timezonefinder-8.0.0.dist-info/METADATA'
adding 'timezonefinder-8.0.0.dist-info/WHEEL'
adding 'timezonefinder-8.0.0.dist-info/entry_points.txt'
adding 'timezonefinder-8.0.0.dist-info/top_level.txt'
adding 'timezonefinder-8.0.0.dist-info/RECORD'
removing build/bdist.linux-aarch64/wheel
Successfully built timezonefinder-8.0.0-cp313-cp313-linux_aarch64.whl
Finished creating a wheel...
Finished executing pypaBuildPhase
Running phase: pythonRuntimeDepsCheckHook
@nix { "action": "setPhase", "phase": "pythonRuntimeDepsCheckHook" }
Executing pythonRuntimeDepsCheck
Checking runtime dependencies for timezonefinder-8.0.0-cp313-cp313-linux_aarch64.whl
  - cffi<2,>=1.15.1 not satisfied by version 2.0.0

x86_64-darwin (sandbox = true)

❌ 4 packages failed to build:
  • python312Packages.timezonefinder
  • python312Packages.timezonefinder.dist
  • python313Packages.timezonefinder
  • python313Packages.timezonefinder.dist
✅ 14 packages built:
  • h3 (h3_3)
  • h3.dev (h3_3.dev)
  • h3_4
  • h3_4.dev
  • postgresql13Packages.h3-pg
  • postgresql14Packages.h3-pg
  • postgresql15Packages.h3-pg
  • postgresql16Packages.h3-pg
  • postgresqlPackages.h3-pg (postgresql17Packages.h3-pg)
  • postgresql18Packages.h3-pg
  • python312Packages.h3
  • python312Packages.h3.dist
  • python313Packages.h3
  • python313Packages.h3.dist
Error logs: `x86_64-darwin`
python312Packages.timezonefinder 
adding 'timezonefinder/flatbuf/shortcut_schema.fbs'
adding 'timezonefinder/flatbuf/shortcut_utils.py'
adding 'timezonefinder/inside_poly_extension/inside_polygon_int.c'
adding 'timezonefinder/inside_poly_extension/inside_polygon_int.h'
adding 'timezonefinder-8.0.0.data/data/DATA_LICENSE'
adding 'timezonefinder-8.0.0.dist-info/licenses/LICENSE'
adding 'timezonefinder-8.0.0.dist-info/METADATA'
adding 'timezonefinder-8.0.0.dist-info/WHEEL'
adding 'timezonefinder-8.0.0.dist-info/entry_points.txt'
adding 'timezonefinder-8.0.0.dist-info/top_level.txt'
adding 'timezonefinder-8.0.0.dist-info/RECORD'
removing build/bdist.macosx-11.3-x86_64/wheel
Successfully built timezonefinder-8.0.0-cp312-cp312-macosx_11_0_x86_64.whl
Finished creating a wheel...
Finished executing pypaBuildPhase
Running phase: pythonRuntimeDepsCheckHook
@nix { "action": "setPhase", "phase": "pythonRuntimeDepsCheckHook" }
Executing pythonRuntimeDepsCheck
Checking runtime dependencies for timezonefinder-8.0.0-cp312-cp312-macosx_11_0_x86_64.whl
  - cffi<2,>=1.15.1 not satisfied by version 2.0.0
python313Packages.timezonefinder 
adding 'timezonefinder/flatbuf/shortcut_schema.fbs'
adding 'timezonefinder/flatbuf/shortcut_utils.py'
adding 'timezonefinder/inside_poly_extension/inside_polygon_int.c'
adding 'timezonefinder/inside_poly_extension/inside_polygon_int.h'
adding 'timezonefinder-8.0.0.data/data/DATA_LICENSE'
adding 'timezonefinder-8.0.0.dist-info/licenses/LICENSE'
adding 'timezonefinder-8.0.0.dist-info/METADATA'
adding 'timezonefinder-8.0.0.dist-info/WHEEL'
adding 'timezonefinder-8.0.0.dist-info/entry_points.txt'
adding 'timezonefinder-8.0.0.dist-info/top_level.txt'
adding 'timezonefinder-8.0.0.dist-info/RECORD'
removing build/bdist.macosx-11.3-x86_64/wheel
Successfully built timezonefinder-8.0.0-cp313-cp313-macosx_11_0_x86_64.whl
Finished creating a wheel...
Finished executing pypaBuildPhase
Running phase: pythonRuntimeDepsCheckHook
@nix { "action": "setPhase", "phase": "pythonRuntimeDepsCheckHook" }
Executing pythonRuntimeDepsCheck
Checking runtime dependencies for timezonefinder-8.0.0-cp313-cp313-macosx_11_0_x86_64.whl
  - cffi<2,>=1.15.1 not satisfied by version 2.0.0

aarch64-darwin (sandbox = true)

❌ 4 packages failed to build:
  • python312Packages.timezonefinder
  • python312Packages.timezonefinder.dist
  • python313Packages.timezonefinder
  • python313Packages.timezonefinder.dist
✅ 14 packages built:
  • h3 (h3_3)
  • h3.dev (h3_3.dev)
  • h3_4
  • h3_4.dev
  • postgresql13Packages.h3-pg
  • postgresql14Packages.h3-pg
  • postgresql15Packages.h3-pg
  • postgresql16Packages.h3-pg
  • postgresqlPackages.h3-pg (postgresql17Packages.h3-pg)
  • postgresql18Packages.h3-pg
  • python312Packages.h3
  • python312Packages.h3.dist
  • python313Packages.h3
  • python313Packages.h3.dist
Error logs: `aarch64-darwin`
python312Packages.timezonefinder 
adding 'timezonefinder/flatbuf/shortcut_schema.fbs'
adding 'timezonefinder/flatbuf/shortcut_utils.py'
adding 'timezonefinder/inside_poly_extension/inside_polygon_int.c'
adding 'timezonefinder/inside_poly_extension/inside_polygon_int.h'
adding 'timezonefinder-8.0.0.data/data/DATA_LICENSE'
adding 'timezonefinder-8.0.0.dist-info/licenses/LICENSE'
adding 'timezonefinder-8.0.0.dist-info/METADATA'
adding 'timezonefinder-8.0.0.dist-info/WHEEL'
adding 'timezonefinder-8.0.0.dist-info/entry_points.txt'
adding 'timezonefinder-8.0.0.dist-info/top_level.txt'
adding 'timezonefinder-8.0.0.dist-info/RECORD'
removing build/bdist.macosx-11.3-arm64/wheel
Successfully built timezonefinder-8.0.0-cp312-cp312-macosx_11_0_arm64.whl
Finished creating a wheel...
Finished executing pypaBuildPhase
Running phase: pythonRuntimeDepsCheckHook
@nix { "action": "setPhase", "phase": "pythonRuntimeDepsCheckHook" }
Executing pythonRuntimeDepsCheck
Checking runtime dependencies for timezonefinder-8.0.0-cp312-cp312-macosx_11_0_arm64.whl
  - cffi<2,>=1.15.1 not satisfied by version 2.0.0
python313Packages.timezonefinder 
adding 'timezonefinder/flatbuf/shortcut_schema.fbs'
adding 'timezonefinder/flatbuf/shortcut_utils.py'
adding 'timezonefinder/inside_poly_extension/inside_polygon_int.c'
adding 'timezonefinder/inside_poly_extension/inside_polygon_int.h'
adding 'timezonefinder-8.0.0.data/data/DATA_LICENSE'
adding 'timezonefinder-8.0.0.dist-info/licenses/LICENSE'
adding 'timezonefinder-8.0.0.dist-info/METADATA'
adding 'timezonefinder-8.0.0.dist-info/WHEEL'
adding 'timezonefinder-8.0.0.dist-info/entry_points.txt'
adding 'timezonefinder-8.0.0.dist-info/top_level.txt'
adding 'timezonefinder-8.0.0.dist-info/RECORD'
removing build/bdist.macosx-11.3-arm64/wheel
Successfully built timezonefinder-8.0.0-cp313-cp313-macosx_11_0_arm64.whl
Finished creating a wheel...
Finished executing pypaBuildPhase
Running phase: pythonRuntimeDepsCheckHook
@nix { "action": "setPhase", "phase": "pythonRuntimeDepsCheckHook" }
Executing pythonRuntimeDepsCheck
Checking runtime dependencies for timezonefinder-8.0.0-cp313-cp313-macosx_11_0_arm64.whl
  - cffi<2,>=1.15.1 not satisfied by version 2.0.0

@nixpkgs-ci nixpkgs-ci bot removed the 9.needs: reviewer This PR currently has no reviewers requested and needs attention. label Oct 21, 2025
@iedame
Copy link
Contributor Author

iedame commented Oct 21, 2025

Looks like timezonefinder needs an update to fix that error:
jannikmi/timezonefinder@0875d69
I guess this PR is fine and those errors can be fixed in a separate PR?

@iedame

This comment was marked as duplicate.

Sign in to view
@iedame
Copy link
Contributor Author

iedame commented Oct 21, 2025

@Sigmanificient this one also counts for h3: h3 = h3_3;

diogotcorreia
diogotcorreia approved these changes Oct 26, 2025
View reviewed changes
Copy link
Member

@diogotcorreia diogotcorreia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocker for #423867

@nixpkgs-ci nixpkgs-ci bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Oct 26, 2025
@diogotcorreia diogotcorreia mentioned this pull request Oct 26, 2025
Merged
20 tasks
@diogotcorreia diogotcorreia self-requested a review October 26, 2025 11:30
diogotcorreia
diogotcorreia reviewed Oct 26, 2025
View reviewed changes
@iedame iedame changed the title h3{_3, _4}: fix build with cmake4 h3, h3_3: fix build with cmake4 Oct 26, 2025
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. and removed 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. labels Oct 26, 2025
diogotcorreia
diogotcorreia approved these changes Oct 27, 2025
View reviewed changes
Copy link
Member

@diogotcorreia diogotcorreia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 454194
Commit: 06c79febc49f15771cda1ac6ba75657fb4078bc6

x86_64-linux

✅ 2 packages built:
  • h3 (h3_3)
  • h3.dev (h3_3.dev)

@nixos-discourse
Copy link

nixos-discourse commented Oct 31, 2025

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/2618

@SigmaSquadron SigmaSquadron added this pull request to the merge queue Oct 31, 2025
@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 2 This PR was reviewed and approved by two persons. and removed 12.approvals: 1 This PR was reviewed and approved by one person. labels Oct 31, 2025
Merged via the queue into NixOS:master with commit e987844 Oct 31, 2025
32 of 34 checks passed
@iedame iedame deleted the cmake4/h3 branch October 31, 2025 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SigmaSquadron SigmaSquadron SigmaSquadron approved these changes

@kalbasit kalbasit Awaiting requested review from kalbasit

+1 more reviewer

@diogotcorreia diogotcorreia diogotcorreia approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 12.approvals: 2 This PR was reviewed and approved by two persons.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@iedame @nixos-discourse @diogotcorreia @SigmaSquadron