Skip to content

grip-search: fix build with cmake4#454193

Merged
Sigmanificient merged 1 commit intoNixOS:masterfrom
iedame:cmake4/grip-search
Oct 23, 2025
Merged

grip-search: fix build with cmake4#454193
Sigmanificient merged 1 commit intoNixOS:masterfrom
iedame:cmake4/grip-search

Conversation

@iedame
Copy link
Contributor

@iedame iedame commented Oct 21, 2025

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Oct 21, 2025
@Sigmanificient Sigmanificient mentioned this pull request Oct 21, 2025
Open
@nixpkgs-ci nixpkgs-ci bot added the 9.needs: reviewer This PR currently has no reviewers requested and needs attention. label Oct 21, 2025
@iedame
Copy link
Contributor Author

iedame commented Oct 21, 2025

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 454193
Commit: 235f38852d9dff2971eebf5b5dd521e36a7b8de5 (subsequent changes)
Merge: 712b483ff6fd7f6f33c9b33dd6909a0662c78d0d

Logs: https://github.com/iedame/nixpkgs-review-gha/actions/runs/18684464655

x86_64-linux

✅ 1 package built:
  • grip-search

aarch64-linux

✅ 1 package built:
  • grip-search

x86_64-darwin (sandbox = true)

✅ 1 package built:
  • grip-search

aarch64-darwin (sandbox = true)

✅ 1 package built:
  • grip-search

mdaniels5757
mdaniels5757 approved these changes Oct 22, 2025
View reviewed changes
Copy link
Member

@mdaniels5757 mdaniels5757 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diff and nixpkgs-review LGTM

@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 1 This PR was reviewed and approved by one person. and removed 9.needs: reviewer This PR currently has no reviewers requested and needs attention. labels Oct 22, 2025
@Sigmanificient Sigmanificient added this pull request to the merge queue Oct 23, 2025
Merged via the queue into NixOS:master with commit bda98b1 Oct 23, 2025
33 of 36 checks passed
@iedame iedame deleted the cmake4/grip-search branch October 23, 2025 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mdaniels5757 mdaniels5757 mdaniels5757 approved these changes

Assignees

No one assigned

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@iedame @mdaniels5757 @Sigmanificient