Skip to content

fix build with cmake 4 for rang and d-seams#454187

Merged
Sigmanificient merged 2 commits intoNixOS:masterfrom
Rexcrazy804:fix-rang
Oct 27, 2025
Merged

fix build with cmake 4 for rang and d-seams#454187
Sigmanificient merged 2 commits intoNixOS:masterfrom
Rexcrazy804:fix-rang

Conversation

@Rexcrazy804
Copy link
Contributor

part of #445447

  • added patch to bump cmake minimum version for rang
  • d-seams performed the same as above ( a package that depends on rang )

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@Rexcrazy804 Rexcrazy804 changed the title rang(+ d-seams): fix build with cmake 4 fix build with cmake 4 for rang and d-seams Oct 21, 2025
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. labels Oct 21, 2025
@nix-owners nix-owners bot requested a review from HaoZeke October 21, 2025 12:22
@Sigmanificient
Copy link
Member

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 454187
Commit: cd0ddf1e7a7e566a0bc2bcfa07bf2ab1d02ae50c (subsequent changes)
Merge: ad52737776bcea4327461f7ce7e6e5f6324febb1

Logs: https://github.com/Sigmanificient/nixpkgs-review-gha/actions/runs/18752644510


x86_64-linux

✅ 2 packages built:
  • d-seams
  • rang

aarch64-linux

✅ 1 package built:
  • rang

x86_64-darwin (sandbox = true)

✅ 1 package built:
  • rang

aarch64-darwin (sandbox = true)

✅ 1 package built:
  • rang

@iedame
Copy link
Contributor

iedame commented Oct 26, 2025

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 454187
Commit: cd0ddf1e7a7e566a0bc2bcfa07bf2ab1d02ae50c (subsequent changes)
Merge: d0091f787d1175c3745ad35719c5d518c3d9aeed

Logs: https://github.com/iedame/nixpkgs-review-gha/actions/runs/18825506346


x86_64-linux

✅ 2 packages built:
  • d-seams
  • rang

aarch64-linux

✅ 1 package built:
  • rang

x86_64-darwin (sandbox = true)

✅ 1 package built:
  • rang

aarch64-darwin (sandbox = true)

✅ 1 package built:
  • rang

Copy link
Contributor

@iedame iedame left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nixpkgs-ci nixpkgs-ci bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Oct 27, 2025
@Sigmanificient Sigmanificient added this pull request to the merge queue Oct 27, 2025
Merged via the queue into NixOS:master with commit ee76447 Oct 27, 2025
33 of 35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants