Skip to content

ericw-tools: fix build with cmake4#454186

Merged
JohnRTitor merged 1 commit intoNixOS:masterfrom
iedame:cmake4/ericw-tools
Oct 28, 2025
Merged

ericw-tools: fix build with cmake4#454186
JohnRTitor merged 1 commit intoNixOS:masterfrom
iedame:cmake4/ericw-tools

Conversation

@iedame
Copy link
Contributor

@iedame iedame commented Oct 21, 2025

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Oct 21, 2025
@nix-owners nix-owners bot requested a review from astro October 21, 2025 12:21
@iedame
Copy link
Contributor Author

iedame commented Oct 21, 2025

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 454186
Commit: 6e50150544474b9eb82a2207c649e4c84f8345ed (subsequent changes)
Merge: 1c14cb58b950353525080e22cc89163ddbcbf244

Logs: https://github.com/iedame/nixpkgs-review-gha/actions/runs/18683871410


x86_64-linux

✅ 3 packages built:
  • ericw-tools
  • ericw-tools.doc
  • ericw-tools.man

aarch64-linux

✅ 3 packages built:
  • ericw-tools
  • ericw-tools.doc
  • ericw-tools.man

x86_64-darwin (sandbox = true)

✅ 3 packages built:
  • ericw-tools
  • ericw-tools.doc
  • ericw-tools.man

aarch64-darwin (sandbox = true)

✅ 3 packages built:
  • ericw-tools
  • ericw-tools.doc
  • ericw-tools.man

@JohnRTitor JohnRTitor added this pull request to the merge queue Oct 28, 2025
Merged via the queue into NixOS:master with commit dd42bb1 Oct 28, 2025
33 of 34 checks passed
@iedame iedame deleted the cmake4/ericw-tools branch October 28, 2025 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants