Skip to content

qjoypad: fix build with cmake 4#454180

Merged
SigmaSquadron merged 1 commit intoNixOS:masterfrom
Rexcrazy804:fix-qjoypad
Oct 22, 2025
Merged

qjoypad: fix build with cmake 4#454180
SigmaSquadron merged 1 commit intoNixOS:masterfrom
Rexcrazy804:fix-qjoypad

Conversation

@Rexcrazy804
Copy link
Contributor

@Rexcrazy804 Rexcrazy804 commented Oct 21, 2025

part of #445447

  • added postPatch to bumb cmake minimum required version

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 9.needs: reviewer This PR currently has no reviewers requested and needs attention. labels Oct 21, 2025
@Sigmanificient Sigmanificient mentioned this pull request Oct 21, 2025
Open
@mdaniels5757
Copy link
Member

mdaniels5757 commented Oct 22, 2025

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 454180 --build-args='-L'
Commit: 3864a2a11a680190f9db01c5a11372b8dae3fd5f (subsequent changes)
Merge: a6e70076790027f208315dc400f62becf87b88db

Logs: https://github.com/mdaniels5757/nixpkgs-review-gha/actions/runs/18701161732

x86_64-linux

✅ 1 package built:
  • qjoypad

aarch64-linux

✅ 1 package built:
  • qjoypad

x86_64-darwin

✅ No rebuilds

aarch64-darwin

✅ No rebuilds

mdaniels5757
mdaniels5757 approved these changes Oct 22, 2025
View reviewed changes
Copy link
Member

@mdaniels5757 mdaniels5757 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved automatically following the successful run of nixpkgs-review.

@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 1 This PR was reviewed and approved by one person. and removed 9.needs: reviewer This PR currently has no reviewers requested and needs attention. labels Oct 22, 2025
@SigmaSquadron SigmaSquadron added this pull request to the merge queue Oct 22, 2025
Merged via the queue into NixOS:master with commit cff7296 Oct 22, 2025
31 of 35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mdaniels5757 mdaniels5757 mdaniels5757 approved these changes

@SigmaSquadron SigmaSquadron SigmaSquadron approved these changes

Assignees

No one assigned

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Rexcrazy804 @mdaniels5757 @SigmaSquadron