Skip to content

ffts: fix build with cmake 4#454166

Merged
SuperSandro2000 merged 1 commit intoNixOS:masterfrom
carlossless:packages/ffts/cmake4-fix
Oct 23, 2025
Merged

ffts: fix build with cmake 4#454166
SuperSandro2000 merged 1 commit intoNixOS:masterfrom
carlossless:packages/ffts/cmake4-fix

Conversation

@carlossless
Copy link
Contributor

@carlossless carlossless commented Oct 21, 2025 •
edited
Loading

Fixes build failure caused by cmake 4 (#445447)

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. labels Oct 21, 2025
@carlossless carlossless mentioned this pull request Oct 21, 2025
Merged
13 tasks
@Sigmanificient Sigmanificient mentioned this pull request Oct 21, 2025
Open
@carlossless
Copy link
Contributor Author

carlossless commented Oct 21, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 454166
Commit: ae67150a8d7e0903894fa4b0c5a8050e13cd7b21

x86_64-linux

✅ 2 packages built:
  • ffts
  • scopehal-apps

aarch64-linux

✅ 2 packages built:
  • ffts
  • scopehal-apps

@carlossless carlossless marked this pull request as ready for review October 21, 2025 17:55
@nix-owners nix-owners bot requested a review from bgamari October 21, 2025 17:56
zimward
zimward approved these changes Oct 23, 2025
View reviewed changes
Copy link
Contributor

@zimward zimward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be fine

@nixpkgs-ci nixpkgs-ci bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Oct 23, 2025
@SuperSandro2000 SuperSandro2000 added this pull request to the merge queue Oct 23, 2025
Merged via the queue into NixOS:master with commit 81fa372 Oct 23, 2025
38 of 40 checks passed
@carlossless carlossless deleted the packages/ffts/cmake4-fix branch October 24, 2025 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bgamari bgamari Awaiting requested review from bgamari

1 more reviewer

@zimward zimward zimward approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@carlossless @zimward @SuperSandro2000