Skip to content

creduce: fix build with cmake4#454157

Merged
Sigmanificient merged 1 commit intoNixOS:masterfrom
iedame:cmake4/creduce
Oct 26, 2025
Merged

creduce: fix build with cmake4#454157
Sigmanificient merged 1 commit intoNixOS:masterfrom
iedame:cmake4/creduce

Conversation

@iedame
Copy link
Contributor

@iedame iedame commented Oct 21, 2025

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Oct 21, 2025
@iedame
Copy link
Contributor Author

iedame commented Oct 21, 2025

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 454157
Commit: 78ad1e7f0fe2c1b9f15311e341b51495b5c043bd (subsequent changes)
Merge: 91d41f515f3d33d2577da869cba52ed9ba725f35

Logs: https://github.com/iedame/nixpkgs-review-gha/actions/runs/18680866321


x86_64-linux

✅ 1 package built:
  • creduce

aarch64-linux

✅ 1 package built:
  • creduce

x86_64-darwin (sandbox = true)

✅ 1 package built:
  • creduce

aarch64-darwin (sandbox = true)

✅ 1 package built:
  • creduce

@nixpkgs-ci nixpkgs-ci bot added the 9.needs: reviewer This PR currently has no reviewers requested and needs attention. label Oct 21, 2025
@nixpkgs-ci nixpkgs-ci bot removed the 9.needs: reviewer This PR currently has no reviewers requested and needs attention. label Oct 22, 2025
Co-authored-by: Michael Daniels <[email protected]>
@mdaniels5757
Copy link
Member

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 454157 --build-args='-L'
Commit: b0912adb84c68732c6f52a6b65d73d21070f7687 (subsequent changes)
Merge: d691a269dd7fc68900216fd5d2df0c34425620ae

Logs: https://github.com/mdaniels5757/nixpkgs-review-gha/actions/runs/18793880680


x86_64-linux

✅ 1 package built:
  • creduce

aarch64-linux

✅ 1 package built:
  • creduce

x86_64-darwin (sandbox = true)

✅ 1 package built:
  • creduce

aarch64-darwin (sandbox = true)

✅ 1 package built:
  • creduce

Copy link
Member

@mdaniels5757 mdaniels5757 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved automatically following the successful run of nixpkgs-review.

@nixpkgs-ci nixpkgs-ci bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Oct 24, 2025
@Sigmanificient Sigmanificient added this pull request to the merge queue Oct 26, 2025
Merged via the queue into NixOS:master with commit 07b5b5e Oct 26, 2025
29 of 31 checks passed
@iedame iedame deleted the cmake4/creduce branch October 26, 2025 04:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants