Skip to content

createrepo_c: fix build with cmake4#454155

Merged
LeSuisse merged 1 commit intoNixOS:masterfrom
iedame:cmake4/createrepo_c
Oct 22, 2025
Merged

createrepo_c: fix build with cmake4#454155
LeSuisse merged 1 commit intoNixOS:masterfrom
iedame:cmake4/createrepo_c

Conversation

@iedame
Copy link
Contributor

@iedame iedame commented Oct 21, 2025

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 9.needs: reviewer This PR currently has no reviewers requested and needs attention. labels Oct 21, 2025
@iedame
Copy link
Contributor Author

iedame commented Oct 21, 2025

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 454155
Commit: 7aaff66a8c443998557fba3330361960c5cfe503 (subsequent changes)
Merge: 69d32ed025b5b0d66fbf728f1bf6ea5e94ef15c4

Logs: https://github.com/iedame/nixpkgs-review-gha/actions/runs/18680850425

x86_64-linux

✅ 3 packages built:
  • createrepo_c
  • dnf5
  • dnf5.man

aarch64-linux

✅ 3 packages built:
  • createrepo_c
  • dnf5
  • dnf5.man

x86_64-darwin (sandbox = true)

✅ 1 package built:
  • createrepo_c

aarch64-darwin (sandbox = true)

✅ 1 package built:
  • createrepo_c

@Sigmanificient Sigmanificient mentioned this pull request Oct 21, 2025
Open
mdaniels5757
mdaniels5757 approved these changes Oct 22, 2025
View reviewed changes
Copy link
Member

@mdaniels5757 mdaniels5757 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diff and nixpkgs-review LGTM

@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 1 This PR was reviewed and approved by one person. and removed 9.needs: reviewer This PR currently has no reviewers requested and needs attention. labels Oct 22, 2025
LeSuisse
LeSuisse approved these changes Oct 22, 2025
View reviewed changes
Copy link
Member

@LeSuisse LeSuisse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, upstream also fixed it but it's interleaved with other changes.

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 454155
Commit: 7aaff66a8c443998557fba3330361960c5cfe503

x86_64-linux

✅ 3 packages built:
  • createrepo_c
  • dnf5
  • dnf5.man

@LeSuisse LeSuisse added this pull request to the merge queue Oct 22, 2025
@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 2 This PR was reviewed and approved by two persons. and removed 12.approvals: 1 This PR was reviewed and approved by one person. labels Oct 22, 2025
Merged via the queue into NixOS:master with commit ba38001 Oct 22, 2025
32 of 35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LeSuisse LeSuisse LeSuisse approved these changes

@mdaniels5757 mdaniels5757 mdaniels5757 approved these changes

Assignees

No one assigned

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 12.approvals: 2 This PR was reviewed and approved by two persons.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@iedame @LeSuisse @mdaniels5757