Skip to content

lenmus: fix build issue due to cmake 4#454044

Merged
Sigmanificient merged 1 commit intoNixOS:masterfrom
andrewzah:lenmus
Oct 23, 2025
Merged

lenmus: fix build issue due to cmake 4#454044
Sigmanificient merged 1 commit intoNixOS:masterfrom
andrewzah:lenmus

Conversation

@andrewzah
Copy link
Contributor

@andrewzah andrewzah commented Oct 21, 2025

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Oct 21, 2025
@andrewzah
Copy link
Contributor Author

andrewzah commented Oct 21, 2025

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 454044
Commit: f0553e3f118ebb8cec9cf906c9d234218b9c3181 (subsequent changes)
Merge: c9c44ffa19e1062c385c6cf2c1b262763ee35c4a

Logs: https://github.com/andrewzah/nixpkgs-review-gha/actions/runs/18669628632

x86_64-linux

✅ 1 package built:
  • lenmus

aarch64-linux

✅ 1 package built:
  • lenmus

x86_64-darwin (sandbox = true)

❌ 1 package failed to build:
  • lenmus
Error logs: `x86_64-darwin`
lenmus 
 4263 |     bool fErrors = false;
      |          ^
[ 95%] Building CXX object CMakeFiles/lenmus.dir/lomse/trunk/src/parser/mnx/lomse_mnx_compiler.cpp.o
1 warning generated.
[ 95%] Building CXX object CMakeFiles/lenmus.dir/lomse/trunk/src/platform/lomse_linux.cpp.o
[ 96%] Building CXX object CMakeFiles/lenmus.dir/lomse/trunk/src/render/lomse_bitmap_drawer.cpp.o
[ 96%] Building CXX object CMakeFiles/lenmus.dir/lomse/trunk/src/render/lomse_calligrapher.cpp.o
[ 96%] Building CXX object CMakeFiles/lenmus.dir/lomse/trunk/src/render/lomse_font_freetype.cpp.o
[ 97%] Building CXX object CMakeFiles/lenmus.dir/lomse/trunk/src/render/lomse_font_storage.cpp.o
/nix/build/nix-21639-1813950762/source/lomse/trunk/src/render/lomse_font_freetype.cpp:140:14: warning: variable 'len' set but not used [-Wunused-but-set-variable]
  140 |     unsigned len = 0;
      |              ^
/nix/build/nix-21639-1813950762/source/lomse/trunk/src/render/lomse_font_freetype.cpp:203:31: error: assigning to 'char *' from 'unsigned char *' converts between pointers to integer types where one is of the unique plain 'char' type and the other is not
  203 |         tags  = outline.tags  + first;
      |                 ~~~~~~~~~~~~~~^~~~~~~
1 warning and 1 error generated.
make[2]: *** [CMakeFiles/lenmus.dir/build.make:3313: CMakeFiles/lenmus.dir/lomse/trunk/src/render/lomse_font_freetype.cpp.o] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [CMakeFiles/Makefile2:155: CMakeFiles/lenmus.dir/all] Error 2
make: *** [Makefile:156: all] Error 2

aarch64-darwin (sandbox = true)

❌ 1 package failed to build:
  • lenmus
Error logs: `aarch64-darwin`
lenmus 
 4263 |     bool fErrors = false;
      |          ^
[ 95%] Building CXX object CMakeFiles/lenmus.dir/lomse/trunk/src/parser/mnx/lomse_mnx_compiler.cpp.o
[ 95%] Building CXX object CMakeFiles/lenmus.dir/lomse/trunk/src/platform/lomse_linux.cpp.o
1 warning generated.
[ 96%] Building CXX object CMakeFiles/lenmus.dir/lomse/trunk/src/render/lomse_bitmap_drawer.cpp.o
[ 96%] Building CXX object CMakeFiles/lenmus.dir/lomse/trunk/src/render/lomse_calligrapher.cpp.o
[ 96%] Building CXX object CMakeFiles/lenmus.dir/lomse/trunk/src/render/lomse_font_freetype.cpp.o
[ 97%] Building CXX object CMakeFiles/lenmus.dir/lomse/trunk/src/render/lomse_font_storage.cpp.o
/nix/build/nix-8937-1523314842/source/lomse/trunk/src/render/lomse_font_freetype.cpp:140:14: warning: variable 'len' set but not used [-Wunused-but-set-variable]
  140 |     unsigned len = 0;
      |              ^
/nix/build/nix-8937-1523314842/source/lomse/trunk/src/render/lomse_font_freetype.cpp:203:31: error: assigning to 'char *' from 'unsigned char *' converts between pointers to integer types where one is of the unique plain 'char' type and the other is not
  203 |         tags  = outline.tags  + first;
      |                 ~~~~~~~~~~~~~~^~~~~~~
1 warning and 1 error generated.
make[2]: *** [CMakeFiles/lenmus.dir/build.make:3313: CMakeFiles/lenmus.dir/lomse/trunk/src/render/lomse_font_freetype.cpp.o] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [CMakeFiles/Makefile2:155: CMakeFiles/lenmus.dir/all] Error 2
make: *** [Makefile:156: all] Error 2

@nixpkgs-ci nixpkgs-ci bot added the 9.needs: reviewer This PR currently has no reviewers requested and needs attention. label Oct 21, 2025
@dotlambda dotlambda mentioned this pull request Oct 21, 2025
Open
mdaniels5757
mdaniels5757 approved these changes Oct 22, 2025
View reviewed changes
Copy link
Member

@mdaniels5757 mdaniels5757 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, darwin failure is unrelated (e.g. https://hydra.nixos.org/build/300112851)

@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 1 This PR was reviewed and approved by one person. and removed 9.needs: reviewer This PR currently has no reviewers requested and needs attention. labels Oct 22, 2025
@Sigmanificient Sigmanificient added this pull request to the merge queue Oct 23, 2025
Merged via the queue into NixOS:master with commit 99c7a5d Oct 23, 2025
34 of 36 checks passed
@andrewzah andrewzah deleted the lenmus branch October 25, 2025 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mdaniels5757 mdaniels5757 mdaniels5757 approved these changes

Assignees

No one assigned

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@andrewzah @mdaniels5757 @Sigmanificient