Skip to content

treewide: Purge stdenv.platform and top-level platform#45403

Merged
Ericson2314 merged 1 commit intoNixOS:masterfrom
obsidiansystems:purge-bare-platform
Aug 20, 2018
Merged

treewide: Purge stdenv.platform and top-level platform#45403
Ericson2314 merged 1 commit intoNixOS:masterfrom
obsidiansystems:purge-bare-platform

Conversation

@Ericson2314
Copy link
Member

@Ericson2314 Ericson2314 commented Aug 20, 2018

Motivation for this change

Progress towards #27069

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

CC @volth

@Ericson2314 Ericson2314 added this to the 18.09 milestone Aug 20, 2018
@Ericson2314 Ericson2314 requested a review from nbp as a code owner August 20, 2018 19:34
@GrahamcOfBorg GrahamcOfBorg added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Aug 20, 2018
@Ericson2314 Ericson2314 merged commit 70a0c15 into NixOS:master Aug 20, 2018
@Ericson2314 Ericson2314 deleted the purge-bare-platform branch August 20, 2018 19:50
@Ericson2314 Ericson2314 mentioned this pull request Aug 20, 2018
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thoughtpolice thoughtpolice Awaiting requested review from thoughtpolice

@matthewbauer matthewbauer Awaiting requested review from matthewbauer

@dezgeg dezgeg Awaiting requested review from dezgeg

@nbp nbp Awaiting requested review from nbp

Assignees

No one assigned

Labels

6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Milestone

18.09

Development

Successfully merging this pull request may close these issues.

2 participants

@Ericson2314 @GrahamcOfBorg