Skip to content

stxxl: fix build with cmake4#453958

Merged
jopejoe1 merged 1 commit intoNixOS:masterfrom
iedame:cmake4/stxxl
Oct 21, 2025
Merged

stxxl: fix build with cmake4#453958
jopejoe1 merged 1 commit intoNixOS:masterfrom
iedame:cmake4/stxxl

Conversation

@iedame
Copy link
Contributor

@iedame iedame commented Oct 20, 2025

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 9.needs: reviewer This PR currently has no reviewers requested and needs attention. labels Oct 20, 2025
@iedame
Copy link
Contributor Author

iedame commented Oct 20, 2025

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 453958
Commit: fd7ff5ba20bfe3c27a1b83d3341ed7ffaf001ede (subsequent changes)
Merge: 61c3e46fa567bdeae6bd19e7a6571daa1b40e279

Logs: https://github.com/iedame/nixpkgs-review-gha/actions/runs/18663582518

x86_64-linux

✅ 1 package built:
  • stxxl

aarch64-linux

✅ 1 package built:
  • stxxl

x86_64-darwin (sandbox = true)

✅ 1 package built:
  • stxxl

aarch64-darwin (sandbox = true)

✅ 1 package built:
  • stxxl

@Sigmanificient Sigmanificient mentioned this pull request Oct 20, 2025
Open
mdaniels5757
mdaniels5757 approved these changes Oct 20, 2025
View reviewed changes
Copy link
Member

@mdaniels5757 mdaniels5757 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diff and nixpkgs-review LGTM.

@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 1 This PR was reviewed and approved by one person. and removed 9.needs: reviewer This PR currently has no reviewers requested and needs attention. labels Oct 20, 2025
@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 2 This PR was reviewed and approved by two persons. and removed 12.approvals: 1 This PR was reviewed and approved by one person. labels Oct 20, 2025
@jopejoe1 jopejoe1 added this pull request to the merge queue Oct 21, 2025
Merged via the queue into NixOS:master with commit 85a03d7 Oct 21, 2025
33 of 37 checks passed
@iedame iedame deleted the cmake4/stxxl branch October 21, 2025 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mdaniels5757 mdaniels5757 mdaniels5757 approved these changes

+1 more reviewer

@ethancedwards8 ethancedwards8 ethancedwards8 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 2 This PR was reviewed and approved by two persons.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@iedame @mdaniels5757 @ethancedwards8 @jopejoe1