Skip to content

surge: fix build with cmake4#453956

Merged
Sigmanificient merged 1 commit intoNixOS:masterfrom
iedame:cmake4/surge
Oct 23, 2025
Merged

surge: fix build with cmake4#453956
Sigmanificient merged 1 commit intoNixOS:masterfrom
iedame:cmake4/surge

Conversation

@iedame
Copy link
Contributor

@iedame iedame commented Oct 20, 2025

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@Sigmanificient Sigmanificient mentioned this pull request Oct 20, 2025
Open
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Oct 20, 2025
@nix-owners nix-owners bot requested review from magnetophon and orivej October 20, 2025 19:21
@iedame
Copy link
Contributor Author

iedame commented Oct 20, 2025

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 453956
Commit: 6154148eb4a37bf95d700c55c8829cdcf39ee5e8 (subsequent changes)
Merge: bd67de94fa084c6f9ee44961d06a8aa3b10d5ae6

Logs: https://github.com/iedame/nixpkgs-review-gha/actions/runs/18662453073

x86_64-linux

✅ 1 package built:
  • surge

aarch64-linux

✅ No rebuilds

x86_64-darwin

✅ No rebuilds

aarch64-darwin

✅ No rebuilds

magnetophon
magnetophon approved these changes Oct 20, 2025
View reviewed changes
Copy link
Member

@magnetophon magnetophon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 453956
Commit: 6154148eb4a37bf95d700c55c8829cdcf39ee5e8

x86_64-linux

✅ 1 package built:
  • surge

@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels Oct 20, 2025
@Sigmanificient Sigmanificient added this pull request to the merge queue Oct 23, 2025
Merged via the queue into NixOS:master with commit 5b57a5e Oct 23, 2025
33 of 35 checks passed
@iedame iedame deleted the cmake4/surge branch October 23, 2025 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@orivej orivej Awaiting requested review from orivej

1 more reviewer

@magnetophon magnetophon magnetophon approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@iedame @magnetophon @Sigmanificient