Skip to content

tangerine: fix build with cmake4#453951

Merged
viraptor merged 1 commit intoNixOS:masterfrom
iedame:cmake4/tangerine
Oct 21, 2025
Merged

tangerine: fix build with cmake4#453951
viraptor merged 1 commit intoNixOS:masterfrom
iedame:cmake4/tangerine

Conversation

@iedame
Copy link
Contributor

@iedame iedame commented Oct 20, 2025

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Oct 20, 2025
@nix-owners nix-owners bot requested a review from viraptor October 20, 2025 19:00
@nixpkgs-ci nixpkgs-ci bot added 9.needs: reviewer This PR currently has no reviewers requested and needs attention. and removed 9.needs: reviewer This PR currently has no reviewers requested and needs attention. labels Oct 20, 2025
@Sigmanificient Sigmanificient mentioned this pull request Oct 20, 2025
Open
@iedame
Copy link
Contributor Author

iedame commented Oct 20, 2025

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 453951
Commit: d6c47de4c65fd1d87817b9671f1643af2af2c293 (subsequent changes)
Merge: 0b96532d4eedba304d75e0171dea4e7f121a4f1a

Logs: https://github.com/iedame/nixpkgs-review-gha/actions/runs/18662457414

x86_64-linux

✅ 1 package built:
  • tangerine

aarch64-linux

✅ 1 package built:
  • tangerine

x86_64-darwin

✅ No rebuilds

aarch64-darwin

✅ No rebuilds

@viraptor viraptor added this pull request to the merge queue Oct 21, 2025
Merged via the queue into NixOS:master with commit c254e80 Oct 21, 2025
30 of 34 checks passed
@iedame iedame deleted the cmake4/tangerine branch October 21, 2025 11:32
@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels Oct 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@viraptor viraptor viraptor approved these changes

Assignees

No one assigned

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@iedame @viraptor