Merged
Conversation
nixpkgs-ci
bot
added
10.rebuild-linux: 101-500
nim65s
reviewed
Oct 20, 2025
Contributor
nim65s
left a comment
nim65s
left a comment
There was a problem hiding this comment.
diff lgtm, builds fine on linux, and the content of the outputs looks fine, thanks !
I'll start nixpkgs-review on x86_64-linux
Contributor
Author
I'll start nixpkgs-review on aarch64-darwin. |
Contributor
Author
|
Contributor
|
Contributor
Author
|
No new failure accroding to hydra-check. I think it's safe to go. |
Contributor
|
About failures in linux :
|
nixpkgs-ci
bot
added
12.approvals: 1
LordGrimmauld
approved these changes
Nov 1, 2025
Contributor
LordGrimmauld
left a comment
LordGrimmauld
left a comment
There was a problem hiding this comment.
overall looks sane, but why are we removing the enable flags? Maintenance load of all the permutations acting potentially unpredictable? Or is there just no scenario in which having them just enabled hurts?
nixpkgs-ci
bot
added
12.approvals: 2
Contributor
Author
|
These removed enable* flags are enabled by default and not referenced in nixpkgs. If anyone need manually set some flags off (e.g. some component not avaialble on exotic platforms) , i can add them back. |
NickCao
approved these changes
Nov 4, 2025
|
I need to at least be able to easily disable |
|
I think it's valuable to maintain optionality for dependencies that are truly optional, even if Nixpkgs itself doesn't exercise those combinations. It preserves a lot of information about how the package itself is designed to work and how its build system works. If we drop those options, one must often resort to reading READMEs or build scripts in the source to discover what is actually optional and what is required. |
Contributor
Author
|
Can you open a new pr to re enable the flag, i will approve for it. |
Contributor
@qbisi didn't you say you'd add those back yourself if they are required? |
Contributor
Author
|
Yes, i am waiting for pr or i can add them back myself. |
Contributor
Author
It's not a hard job. but i think pr opened by @de11n will meet his need most probably. |
|
I will open a PR. |
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.