Skip to content

toxvpn: fix build with cmake4#453918

Merged
Sigmanificient merged 1 commit intoNixOS:masterfrom
iedame:cmake4/toxvpn
Oct 23, 2025
Merged

toxvpn: fix build with cmake4#453918
Sigmanificient merged 1 commit intoNixOS:masterfrom
iedame:cmake4/toxvpn

Conversation

@iedame
Copy link
Contributor

@iedame iedame commented Oct 20, 2025

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Oct 20, 2025
@Sigmanificient
Copy link
Member

Sigmanificient commented Oct 20, 2025

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 453918
Commit: d6d9fdd74279f8910b6bf83989b460d4d8a05ece (subsequent changes)
Merge: c2d75e25871b1a1eefd2cba5f3037e6b662486c5

Logs: https://github.com/Sigmanificient/nixpkgs-review-gha/actions/runs/18659850715

x86_64-linux

✅ 1 package built:
  • toxvpn

aarch64-linux

✅ 1 package built:
  • toxvpn

x86_64-darwin (sandbox = true)

✅ 1 package built:
  • toxvpn

aarch64-darwin (sandbox = true)

✅ 1 package built:
  • toxvpn

@iedame
Copy link
Contributor Author

iedame commented Oct 20, 2025

Still missing from the #445447 list

@Sigmanificient Sigmanificient mentioned this pull request Oct 20, 2025
Open
toonn
toonn approved these changes Oct 23, 2025
View reviewed changes
Copy link
Contributor

@toonn toonn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels Oct 23, 2025
@Sigmanificient Sigmanificient added this pull request to the merge queue Oct 23, 2025
Merged via the queue into NixOS:master with commit efe71b8 Oct 23, 2025
34 of 36 checks passed
@iedame iedame deleted the cmake4/toxvpn branch October 23, 2025 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@toonn toonn toonn approved these changes

@cleverca22 cleverca22 Awaiting requested review from cleverca22

@craigem craigem Awaiting requested review from craigem

@obadz obadz Awaiting requested review from obadz

Assignees

No one assigned

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@iedame @Sigmanificient @toonn