Skip to content

translatelocally: fix build with cmake4#453906

Merged
Sigmanificient merged 1 commit intoNixOS:masterfrom
iedame:cmake4/translatelocally
Oct 23, 2025
Merged

translatelocally: fix build with cmake4#453906
Sigmanificient merged 1 commit intoNixOS:masterfrom
iedame:cmake4/translatelocally

Conversation

@iedame
Copy link
Contributor

@iedame iedame commented Oct 20, 2025

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Oct 20, 2025
@nix-owners nix-owners bot requested a review from pacien October 20, 2025 17:04
@Sigmanificient Sigmanificient mentioned this pull request Oct 20, 2025
Open
@iedame iedame force-pushed the cmake4/translatelocally branch from 42e94fe to 85e3755 Compare October 20, 2025 17:56
@iedame

This comment was marked as outdated.

Sign in to view
pacien
pacien approved these changes Oct 22, 2025
View reviewed changes
Copy link
Contributor

@pacien pacien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Patch looking good to me.
Waiting for translatelocally.passthru.tests to run on the CI.
Good for merging if it passes.

@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels Oct 22, 2025
@iedame iedame force-pushed the cmake4/translatelocally branch from 85e3755 to bfaa803 Compare October 22, 2025 17:39
@iedame
Copy link
Contributor Author

iedame commented Oct 22, 2025

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 453906
Commit: bfaa803e7dc276e35e608c29196905411ba09c1c (subsequent changes)
Merge: 75fa02a6428d76ae382f01a2a3aae99f57ec2cf9

Logs: https://github.com/iedame/nixpkgs-review-gha/actions/runs/18724853216

x86_64-linux

✅ 1 package built:
  • translatelocally

aarch64-linux

✅ 1 package built:
  • translatelocally

x86_64-darwin

✅ No rebuilds

aarch64-darwin

✅ No rebuilds

@Sigmanificient Sigmanificient added this pull request to the merge queue Oct 23, 2025
Merged via the queue into NixOS:master with commit d114871 Oct 23, 2025
27 of 30 checks passed
@iedame iedame deleted the cmake4/translatelocally branch October 23, 2025 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@pacien pacien pacien approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@iedame @pacien @Sigmanificient