Skip to content

CubicSDR: fix build with cmake4#453901

Merged
Sigmanificient merged 1 commit intoNixOS:masterfrom
gshipunov:0xa/cubicsdr
Oct 23, 2025
Merged

CubicSDR: fix build with cmake4#453901
Sigmanificient merged 1 commit intoNixOS:masterfrom
gshipunov:0xa/cubicsdr

Conversation

@gshipunov
Copy link
Member

@gshipunov gshipunov commented Oct 20, 2025

#445447

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@gshipunov
Copy link
Member Author

gshipunov commented Oct 20, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 453901
Commit: 8ce6d586dd29e66e6839816e1d9f4052256884b2

x86_64-linux

✅ 1 package built:
  • cubicsdr

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Oct 20, 2025
@nix-owners nix-owners bot requested a review from lasandell October 20, 2025 16:18
@Sigmanificient Sigmanificient mentioned this pull request Oct 20, 2025
Open
@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels Oct 21, 2025
Sigmanificient
Sigmanificient requested changes Oct 22, 2025
View reviewed changes
@gshipunov
Copy link
Member Author

gshipunov commented Oct 22, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 453901
Commit: 4704a316771e45164f4747471f4cb146d4101370

x86_64-linux

✅ 1 package built:
  • cubicsdr

@Sigmanificient Sigmanificient added this pull request to the merge queue Oct 23, 2025
Merged via the queue into NixOS:master with commit 1fdf848 Oct 23, 2025
27 of 30 checks passed
@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 2 This PR was reviewed and approved by two persons. and removed 12.approvals: 1 This PR was reviewed and approved by one person. labels Oct 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Sigmanificient Sigmanificient Sigmanificient approved these changes

+1 more reviewer

@lasandell lasandell lasandell approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 2 This PR was reviewed and approved by two persons. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@gshipunov @lasandell @Sigmanificient