Skip to content

Comments

nixos/hardware.dslogic: init#453877

Open
antono wants to merge 1 commit intoNixOS:masterfrom
antono:hardware-dslogic
Open

nixos/hardware.dslogic: init#453877
antono wants to merge 1 commit intoNixOS:masterfrom
antono:hardware-dslogic

Conversation

@antono
Copy link
Contributor

@antono antono commented Oct 20, 2025 •
edited
Loading

This PR adds support for DreamSourceLab DSLogic devices by creating a new NixOS hardware module that provides udev rules.

  • Adds a new hardware module for DSLogic device support
  • Includes udev rules for USB device access permissions

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

Copilot AI review requested due to automatic review settings October 20, 2025 14:04

This comment was marked as spam.

Sign in to view

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 6.topic: hardware Drivers, Firmware and Kernels labels Oct 20, 2025
@antono
Copy link
Contributor Author

antono commented Oct 20, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 453877
Commit: 63549eb9e09f493b4bc7113df483d98c14f0de07

x86_64-linux

⏩ 2 packages blacklisted:
  • nixos-install-tools
  • tests.nixos-functions.nixos-test

@nixpkgs-ci nixpkgs-ci bot added the 9.needs: reviewer This PR currently has no reviewers requested and needs attention. label Oct 20, 2025
@antono antono changed the title Udev rules and software for Dream DreamSourceLab DSLogic devices Udev rules and software for DreamSourceLab DSLogic devices Oct 20, 2025
@antono antono changed the title Udev rules and software for DreamSourceLab DSLogic devices Udev rules for DreamSourceLab DSLogic devices Oct 21, 2025
@antono antono changed the title Udev rules for DreamSourceLab DSLogic devices Udev rules for DSLogic devices Oct 21, 2025
@h7x4 h7x4 added the 8.has: module (new) This PR adds a module in `nixos/` label Oct 23, 2025
das-g
das-g suggested changes Oct 28, 2025
View reviewed changes
Copy link
Member

@das-g das-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please squash your commits and give the resulting commit a commit message conformant to Commit conventions for changes to nixos.

See also https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md#commit-conventions

nixos/modules/hardware/dslogic.nix
in

{
options.hardware.dslogic.enable = lib.mkEnableOption "udev rules DreamSourceLab DSLogic devices";
Copy link
Member

@das-g das-g Oct 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
options.hardware.dslogic.enable = lib.mkEnableOption "udev rules DreamSourceLab DSLogic devices";
options.hardware.dslogic.enable = lib.mkEnableOption "Whether to enable udev rules for DreamSourceLab DSLogic devices";

Copy link
Contributor Author

@antono antono Oct 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As i understand lib.mkEnableOption adds exactly this prefix:

nixpkgs/lib/options.nix

Line 98 in 4683562

mkEnableOption =

Your suggestion would be true for lib.mkOption

Copy link
Contributor

@wolfgangwalther wolfgangwalther Nov 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The additional "for" would still be required for correct grammatic, right?

@nixpkgs-ci nixpkgs-ci bot removed the 9.needs: reviewer This PR currently has no reviewers requested and needs attention. label Oct 28, 2025
@antono
nixos/hardware.dslogic: init
f36c55e 
This commit adds support for DreamSourceLab DSLogic devices by creating
a new NixOS hardware module that provides udev rules.
@antono
Copy link
Contributor Author

antono commented Oct 30, 2025 •
edited
Loading

Please squash your commits and give the resulting commit a commit message conformant to Commit conventions for changes to nixos.

See also https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md#commit-conventions

✔️ Done

Estis interese ekkoni de via profilo, ke vi partoprenas Esperanto agado :) Saluton do!

das-g
das-g approved these changes Oct 30, 2025
View reviewed changes
Copy link
Member

@das-g das-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. (I didn't test it, though, and I know near-nothing about udev rules.)

Tiu ŝanĝo ŝajnas bona al mi. (Sed mi ne provis ĝin, kaj mi tute ne spertas pri udev-reguloj.)

@nixpkgs-ci nixpkgs-ci bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Oct 30, 2025
@wolfgangwalther
Copy link
Contributor

wolfgangwalther commented Nov 6, 2025

@antono, I see you are maintaining a few packages in Nixpkgs, but are not part of the @NixOS/nixpkgs-maintainers team. You likely missed the invite when the team was created. Without membership in this team, you can't be requested for review for your packages properly. Please see https://github.com/NixOS/nixpkgs/tree/master/maintainers#tools-for-maintainers on how to request another invite to join the team.

@wolfgangwalther wolfgangwalther changed the title Udev rules for DSLogic devices nixos/hardware.dslogic: init Nov 6, 2025
@antono
Copy link
Contributor Author

antono commented Nov 29, 2025

@antono, I see you are maintaining a few packages in Nixpkgs, but are not part of the @NixOS/nixpkgs-maintainers team. You likely missed the invite when the team was created. Without membership in this team, you can't be requested for review for your packages properly. Please see https://github.com/NixOS/nixpkgs/tree/master/maintainers#tools-for-maintainers on how to request another invite to join the team.

Thanks. Applied and joined the team.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@wolfgangwalther wolfgangwalther Awaiting requested review from wolfgangwalther

+1 more reviewer

@das-g das-g das-g approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

6.topic: hardware Drivers, Firmware and Kernels 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (new) This PR adds a module in `nixos/` 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@antono @wolfgangwalther @das-g @h7x4