Skip to content

tiscamera: fix build issue due to cmake 4#453875

Merged
Sigmanificient merged 1 commit intoNixOS:masterfrom
andrewzah:tiscamera
Oct 31, 2025
Merged

tiscamera: fix build issue due to cmake 4#453875
Sigmanificient merged 1 commit intoNixOS:masterfrom
andrewzah:tiscamera

Conversation

@andrewzah
Copy link
Contributor

@andrewzah andrewzah commented Oct 20, 2025

See #445447.

Notes:

  • There have been no tagged releases since 2023, but the master branch had commits as of 2 weeks ago
  • I spotted this during the build, should I add libsysprof-capture to buildInputs? 
    Package 'sysprof-capture-4', required by 'glib-2.0', not found
Package sysprof-capture-4 was not found in the pkg-config search path.
Perhaps you should add the directory containing `sysprof-capture-4.pc'
to the PKG_CONFIG_PATH environment variable

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@Sigmanificient Sigmanificient mentioned this pull request Oct 20, 2025
Open
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Oct 21, 2025
@nix-owners nix-owners bot requested a review from jraygauthier October 21, 2025 01:33
@andrewzah
Copy link
Contributor Author

andrewzah commented Oct 21, 2025

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 453875
Commit: d7b4f13e14017c19da56a8af17323209b7c890da (subsequent changes)
Merge: d858c47bcbf6ae0f3e23e0b5534930b1317266c1

Logs: https://github.com/andrewzah/nixpkgs-review-gha/actions/runs/18669899903

x86_64-linux

✅ 1 package built:
  • tiscamera

aarch64-linux

✅ 1 package built:
  • tiscamera

x86_64-darwin

✅ No rebuilds

aarch64-darwin

✅ No rebuilds

jraygauthier
jraygauthier approved these changes Oct 29, 2025
View reviewed changes
Copy link
Member

@jraygauthier jraygauthier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

About

I spotted this during the build, should I add libsysprof-capture to buildInputs?

No idea. I no longer have access to any tiscamera HW to test the package.

@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels Oct 29, 2025
@Sigmanificient Sigmanificient added this pull request to the merge queue Oct 31, 2025
@Sigmanificient
Copy link
Member

Sigmanificient commented Oct 31, 2025

Lets fix the build and keep it as is for now, but it would be nice to find someone that can properly maintain the package

Merged via the queue into NixOS:master with commit b8df1f9 Oct 31, 2025
34 of 35 checks passed
@andrewzah andrewzah deleted the tiscamera branch November 3, 2025 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@jraygauthier jraygauthier jraygauthier approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@andrewzah @Sigmanificient @jraygauthier