Skip to content

uhub: fix build with cmake4#453855

Merged
SuperSandro2000 merged 1 commit intoNixOS:masterfrom
iedame:cmake4/uhub
Oct 20, 2025
Merged

uhub: fix build with cmake4#453855
SuperSandro2000 merged 1 commit intoNixOS:masterfrom
iedame:cmake4/uhub

Conversation

@iedame
Copy link
Contributor

@iedame iedame commented Oct 20, 2025

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 9.needs: reviewer This PR currently has no reviewers requested and needs attention. labels Oct 20, 2025
@iedame
Copy link
Contributor Author

iedame commented Oct 20, 2025

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 453855
Commit: 421803a54e3e266b3c4d381a3176194dc9086ccc (subsequent changes)
Merge: 2801e6103456b63229cdef2239e109e7fa4a77a5

Logs: https://github.com/iedame/nixpkgs-review-gha/actions/runs/18652918215


x86_64-linux

✅ 1 package built:
  • uhub

aarch64-linux

✅ 1 package built:
  • uhub

x86_64-darwin

No rebuilds


aarch64-darwin

No rebuilds

@jasonxue1

This comment was marked as duplicate.

Copy link
Member

@jasonxue1 jasonxue1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved automatically following the successful run of nixpkgs-review.

@jasonxue1 jasonxue1 added 12.approvals: 1 This PR was reviewed and approved by one person. and removed 9.needs: reviewer This PR currently has no reviewers requested and needs attention. labels Oct 20, 2025
@SuperSandro2000 SuperSandro2000 added this pull request to the merge queue Oct 20, 2025
Merged via the queue into NixOS:master with commit 8a53468 Oct 20, 2025
31 of 35 checks passed
@iedame iedame deleted the cmake4/uhub branch October 20, 2025 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants