Skip to content

ursadb: fix build with cmake4#453814

Merged
SuperSandro2000 merged 1 commit intoNixOS:masterfrom
iedame:cmake4/ursadb
Oct 22, 2025
Merged

ursadb: fix build with cmake4#453814
SuperSandro2000 merged 1 commit intoNixOS:masterfrom
iedame:cmake4/ursadb

Conversation

@iedame
Copy link
Contributor

@iedame iedame commented Oct 20, 2025

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@Sigmanificient Sigmanificient mentioned this pull request Oct 20, 2025
Open
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 9.needs: reviewer This PR currently has no reviewers requested and needs attention. labels Oct 20, 2025
@iedame

This comment was marked as outdated.

Sign in to view
@jasonxue1
Copy link
Member

jasonxue1 commented Oct 20, 2025

See https://hydra.nixos.org/job/nixpkgs/trunk/ursadb.aarch64-linux/all.
It failed in aarch64-linux for over a year, maybe should be marked as broken.

@SuperSandro2000
Copy link
Member

SuperSandro2000 commented Oct 20, 2025

Can you mark it broken? That would be champ.

@iedame
Copy link
Contributor Author

iedame commented Oct 20, 2025

Can you mark it broken? That would be champ.

Sure, one sec!

@iedame
Copy link
Contributor Author

iedame commented Oct 20, 2025

oops, one sec. fixing...

@iedame
Copy link
Contributor Author

iedame commented Oct 20, 2025 •
edited
Loading

Changed it to linux-only and broken on aarch64-linux, since it was marked as broken on darwin for a long time already.

@iedame

This comment was marked as outdated.

Sign in to view
jasonxue1
jasonxue1 reviewed Oct 20, 2025
View reviewed changes
Copy link
Member

@jasonxue1 jasonxue1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jasonxue1
Copy link
Member

jasonxue1 commented Oct 20, 2025

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 453814
Commit: e1119cddefed5d84f8d9b4b85f6bf412afd586f7 (subsequent changes)
Merge: 6e8587bac22374db432437a3fb4826d6e55fde0c

Logs: https://github.com/jasonxue1/nixpkgs-review-gha/actions/runs/18655154276

x86_64-linux

✅ 1 package built:
  • ursadb

aarch64-linux

✅ No rebuilds

jasonxue1
jasonxue1 approved these changes Oct 20, 2025
View reviewed changes
Copy link
Member

@jasonxue1 jasonxue1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved automatically following the successful run of nixpkgs-review.

@jasonxue1 jasonxue1 added 12.approvals: 1 This PR was reviewed and approved by one person. and removed 9.needs: reviewer This PR currently has no reviewers requested and needs attention. labels Oct 20, 2025
@iedame
Copy link
Contributor Author

iedame commented Oct 21, 2025

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 453814
Commit: e5d67461cbd667d366b949b6ca90e10efffa5071 (subsequent changes)
Merge: b3620876ba9c56ab04ba4d327c53058e120bcca3

Logs: https://github.com/iedame/nixpkgs-review-gha/actions/runs/18696730407

x86_64-linux

✅ 1 package built:
  • ursadb

aarch64-linux

✅ No rebuilds

x86_64-darwin

✅ No rebuilds

aarch64-darwin

✅ No rebuilds

@SuperSandro2000 SuperSandro2000 added this pull request to the merge queue Oct 22, 2025
Merged via the queue into NixOS:master with commit ea07ba9 Oct 22, 2025
26 of 30 checks passed
@iedame iedame deleted the cmake4/ursadb branch October 22, 2025 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SuperSandro2000 SuperSandro2000 Awaiting requested review from SuperSandro2000

1 more reviewer

@jasonxue1 jasonxue1 jasonxue1 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@iedame @jasonxue1 @SuperSandro2000