Skip to content

localproxy: fix build with cmake 4#453693

Merged
Sigmanificient merged 1 commit intoNixOS:masterfrom
ethancedwards8:localproxy-cmake
Oct 23, 2025
Merged

localproxy: fix build with cmake 4#453693
Sigmanificient merged 1 commit intoNixOS:masterfrom
ethancedwards8:localproxy-cmake

Conversation

@ethancedwards8
Copy link
Member

@ethancedwards8 ethancedwards8 commented Oct 20, 2025

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@ethancedwards8
localproxy: fix build with cmake 4
bfa8487 
Signed-off-by: Ethan Carter Edwards <[email protected]>
@ethancedwards8
Copy link
Member Author

ethancedwards8 commented Oct 20, 2025

Related: #445447

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Oct 20, 2025
@nix-owners nix-owners bot requested a review from 70m6 October 20, 2025 03:11
@ethancedwards8
Copy link
Member Author

ethancedwards8 commented Oct 20, 2025

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 453693
Commit: bfa8487e98c4f70ed354f3c914d0544594ece905 (subsequent changes)
Merge: 259330135ecf010a67a484ffba1aeb9de07e545e

Logs: https://github.com/ethancedwards8/nixpkgs-review-gha/actions/runs/18640815476

Download packages from cache:
  • x86_64-linux 
    nix-store -r --add-root nixpkgs-pr-453693-x86_64-linux \
  --option binary-caches 'https://cache.nixos.org/ https://ethancedwards8.cachix.org' \
  --option trusted-public-keys '
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  ethancedwards8.cachix.org-1:YMasjqyFnDreRQ9GXmnPIshT3tYyFHE2lUiNhbyIxOc=
  ' \
  /nix/store/q5404s3jz69p30rn0z18fg1zfs18g7wg-localproxy-3.1.2
  • aarch64-linux 
    nix-store -r --add-root nixpkgs-pr-453693-aarch64-linux \
  --option binary-caches 'https://cache.nixos.org/ https://ethancedwards8.cachix.org' \
  --option trusted-public-keys '
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  ethancedwards8.cachix.org-1:YMasjqyFnDreRQ9GXmnPIshT3tYyFHE2lUiNhbyIxOc=
  ' \
  /nix/store/8nqdnpyz5gmr5d11z4h6sd74m9vc2zp8-localproxy-3.1.2
  • x86_64-darwin 
    nix-store -r --add-root nixpkgs-pr-453693-x86_64-darwin \
  --option binary-caches 'https://cache.nixos.org/ https://ethancedwards8.cachix.org' \
  --option trusted-public-keys '
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  ethancedwards8.cachix.org-1:YMasjqyFnDreRQ9GXmnPIshT3tYyFHE2lUiNhbyIxOc=
  ' \
  /nix/store/i4zbsghk2fx1bhzrn96i8fh2415c1v23-localproxy-3.1.2
  • aarch64-darwin 
    nix-store -r --add-root nixpkgs-pr-453693-aarch64-darwin \
  --option binary-caches 'https://cache.nixos.org/ https://ethancedwards8.cachix.org' \
  --option trusted-public-keys '
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  ethancedwards8.cachix.org-1:YMasjqyFnDreRQ9GXmnPIshT3tYyFHE2lUiNhbyIxOc=
  ' \
  /nix/store/fz01vd69zyvlz5k5yl1aiip2aqd6jzgl-localproxy-3.1.2

x86_64-linux

✅ 1 package built:
  • localproxy

aarch64-linux

✅ 1 package built:
  • localproxy

x86_64-darwin (sandbox = true)

✅ 1 package built:
  • localproxy

aarch64-darwin (sandbox = true)

✅ 1 package built:
  • localproxy

@Sigmanificient Sigmanificient mentioned this pull request Oct 20, 2025
Open
@Sigmanificient Sigmanificient added this pull request to the merge queue Oct 23, 2025
Merged via the queue into NixOS:master with commit c33023d Oct 23, 2025
32 of 34 checks passed
@ethancedwards8 ethancedwards8 deleted the localproxy-cmake branch January 15, 2026 05:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@70m6 70m6 Awaiting requested review from 70m6

Assignees

No one assigned

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ethancedwards8 @Sigmanificient