Skip to content

unnamed-sdvx-clone: 0.6.0 -> 0.6.0-unstable-2025-07-31#453634

Merged
Sigmanificient merged 1 commit intoNixOS:masterfrom
mdaniels5757:unnamed-sdvx-clone
Oct 20, 2025
Merged

unnamed-sdvx-clone: 0.6.0 -> 0.6.0-unstable-2025-07-31#453634
Sigmanificient merged 1 commit intoNixOS:masterfrom
mdaniels5757:unnamed-sdvx-clone

Conversation

@mdaniels5757
Copy link
Member

@mdaniels5757 mdaniels5757 commented Oct 19, 2025 •
edited
Loading

Diff: Drewol/unnamed-sdvx-clone@260b050...2472fcc

Contains a CMake 4 fix from upstream. (Tracking: #445447).

Closes: #453589
Closes: #453596

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • Nixpkgs 25.11 Release Notes (or backporting 24.11 and 25.05 Nixpkgs Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
  • NixOS 25.11 Release Notes (or backporting 24.11 and 25.05 NixOS Release notes)
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other contributing documentation in corresponding paths.

Add a 👍 reaction to pull requests you find important.

@mdaniels5757 mdaniels5757 mentioned this pull request Oct 19, 2025
Closed
13 tasks
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Oct 19, 2025
@nix-owners nix-owners bot requested a review from Sakooooo October 19, 2025 22:40
@nixpkgs-ci nixpkgs-ci bot added the 9.needs: reviewer This PR currently has no reviewers requested and needs attention. label Oct 19, 2025
@Sigmanificient Sigmanificient mentioned this pull request Oct 19, 2025
Open
@nixpkgs-ci nixpkgs-ci bot removed the 9.needs: reviewer This PR currently has no reviewers requested and needs attention. label Oct 19, 2025
@Sigmanificient
Copy link
Member

Sigmanificient commented Oct 20, 2025

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 453634
Commit: c1588394c29c0e82abf445e27fbd90d85a942d83 (subsequent changes)
Merge: 73d3385dba1e7e77dfa2a80baf675b0974c49a41

Logs: https://github.com/Sigmanificient/nixpkgs-review-gha/actions/runs/18638959523

x86_64-linux

✅ 1 package built:
  • unnamed-sdvx-clone

aarch64-linux

✅ 1 package built:
  • unnamed-sdvx-clone

Sakooooo
Sakooooo approved these changes Oct 20, 2025
View reviewed changes
Copy link
Contributor

@Sakooooo Sakooooo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels Oct 20, 2025
@Sigmanificient Sigmanificient added this pull request to the merge queue Oct 20, 2025
Merged via the queue into NixOS:master with commit 1a5b87f Oct 20, 2025
36 of 39 checks passed
@mdaniels5757 mdaniels5757 deleted the unnamed-sdvx-clone branch October 20, 2025 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@Sakooooo Sakooooo Sakooooo approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Build failure: unnamed-sdvx-clone

3 participants

@mdaniels5757 @Sigmanificient @Sakooooo