Skip to content

rkrlv2: fix cmake 4 build, modernize#453626

Merged
vcunat merged 2 commits intoNixOS:masterfrom
ethancedwards8:rkrlv2
Oct 27, 2025
Merged

rkrlv2: fix cmake 4 build, modernize#453626
vcunat merged 2 commits intoNixOS:masterfrom
ethancedwards8:rkrlv2

Conversation

@ethancedwards8
Copy link
Member

@ethancedwards8 ethancedwards8 commented Oct 19, 2025 •
edited by vcunat
Loading

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@ethancedwards8
rkrlv2: fix build with cmake 4
e72bb18 
Signed-off-by: Ethan Carter Edwards <[email protected]>
@ethancedwards8
rkrlv2: modernize
c28b163 
Signed-off-by: Ethan Carter Edwards <[email protected]>
@ethancedwards8
Copy link
Member Author

ethancedwards8 commented Oct 19, 2025

Related: #445447

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Oct 19, 2025
@nix-owners nix-owners bot requested a review from joelmo October 19, 2025 22:08
@ethancedwards8
Copy link
Member Author

ethancedwards8 commented Oct 19, 2025

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 453626
Commit: c28b163fb5690502c383c71ef82fd0e206513485 (subsequent changes)
Merge: 78a3aaf832402a59ae768e921d7f5b90b7607a0d

Logs: https://github.com/ethancedwards8/nixpkgs-review-gha/actions/runs/18636745125

Download packages from cache:
  • x86_64-linux 
    nix-store -r --add-root nixpkgs-pr-453626-x86_64-linux \
  --option binary-caches 'https://cache.nixos.org/ https://ethancedwards8.cachix.org' \
  --option trusted-public-keys '
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  ethancedwards8.cachix.org-1:YMasjqyFnDreRQ9GXmnPIshT3tYyFHE2lUiNhbyIxOc=
  ' \
  /nix/store/nb62icwxdkhikmz6ffpqd3q536ndskhk-rkrlv2-beta_3
  • x86_64-darwin 
    nix-store -r --add-root nixpkgs-pr-453626-x86_64-darwin \
  --option binary-caches 'https://cache.nixos.org/ https://ethancedwards8.cachix.org' \
  --option trusted-public-keys '
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  ethancedwards8.cachix.org-1:YMasjqyFnDreRQ9GXmnPIshT3tYyFHE2lUiNhbyIxOc=
  ' \
  /nix/store/ml5vnjjwik3n8qyfbj4wbxazs5s67gh4-rkrlv2-beta_3

x86_64-linux

✅ 1 package built:
  • rkrlv2

aarch64-linux

✅ No rebuilds

x86_64-darwin (sandbox = true)

✅ 1 package built:
  • rkrlv2

aarch64-darwin

✅ No rebuilds

@mdaniels5757
Copy link
Member

mdaniels5757 commented Oct 19, 2025

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 453626 --build-args='-L'
Commit: c28b163fb5690502c383c71ef82fd0e206513485 (subsequent changes)
Merge: 1285969f1cf14d867e06289be137177dc656eb2d

Logs: https://github.com/mdaniels5757/nixpkgs-review-gha/actions/runs/18636797016

x86_64-linux

✅ 1 package built:
  • rkrlv2

aarch64-linux

✅ No rebuilds

x86_64-darwin (sandbox = true)

✅ 1 package built:
  • rkrlv2

aarch64-darwin

✅ No rebuilds

mdaniels5757
mdaniels5757 approved these changes Oct 19, 2025
View reviewed changes
Copy link
Member

@mdaniels5757 mdaniels5757 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved automatically following the successful run of nixpkgs-review.

@nixpkgs-ci nixpkgs-ci bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Oct 19, 2025
@Sigmanificient Sigmanificient mentioned this pull request Oct 19, 2025
Open
@iedame iedame mentioned this pull request Oct 26, 2025
Closed
13 tasks
iedame
iedame approved these changes Oct 26, 2025
View reviewed changes
Copy link
Contributor

@iedame iedame left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 2 This PR was reviewed and approved by two persons. and removed 12.approvals: 1 This PR was reviewed and approved by one person. labels Oct 26, 2025
@magnetophon
Copy link
Member

magnetophon commented Oct 26, 2025

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 453626
Commit: c28b163fb5690502c383c71ef82fd0e206513485 (subsequent changes)
Merge: 89507aa108eb605af536f4786d3648475b2493e0

Logs: https://github.com/magnetophon/nixpkgs-review-gha/actions/runs/18819577598

x86_64-linux

✅ 1 package built:
  • rkrlv2

aarch64-linux

✅ No rebuilds

x86_64-darwin (sandbox = true)

✅ 1 package built:
  • rkrlv2

aarch64-darwin

✅ No rebuilds

magnetophon
magnetophon approved these changes Oct 26, 2025
View reviewed changes
Copy link
Member

@magnetophon magnetophon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved automatically following the successful run of nixpkgs-review.

@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 3+ This PR was reviewed and approved by three or more persons. and removed 12.approvals: 2 This PR was reviewed and approved by two persons. labels Oct 26, 2025
@vcunat vcunat added this pull request to the merge queue Oct 27, 2025
Merged via the queue into NixOS:master with commit 7dfbac1 Oct 27, 2025
41 of 42 checks passed
@ethancedwards8 ethancedwards8 deleted the rkrlv2 branch January 15, 2026 05:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mdaniels5757 mdaniels5757 mdaniels5757 approved these changes

@joelmo joelmo Awaiting requested review from joelmo

@Sigmanificient Sigmanificient Awaiting requested review from Sigmanificient

+2 more reviewers

@iedame iedame iedame approved these changes

@magnetophon magnetophon magnetophon approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 3+ This PR was reviewed and approved by three or more persons.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ethancedwards8 @mdaniels5757 @magnetophon @iedame @vcunat